Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "raw" string tokens be added to the set of tokens with text? #59391

Closed
AlekseyTs opened this issue Feb 8, 2022 · 2 comments · Fixed by #59642
Closed

Should "raw" string tokens be added to the set of tokens with text? #59391

AlekseyTs opened this issue Feb 8, 2022 · 2 comments · Fixed by #59642
Assignees

Comments

@AlekseyTs
Copy link
Contributor

SyntaxKind.cs:

        SingleLineRawStringLiteralToken = 9072,
        MultiLineRawStringLiteralToken = 9073,

        InterpolatedSingleLineRawStringStartToken = 9080,   // $"""
        InterpolatedMultiLineRawStringStartToken = 9081,    // $""" (whitespace and newline are included in the Text for this token)
        InterpolatedRawStringEndToken = 9082,               // """ (preceding whitespace and newline are included in the Text for this token)

It looks like other tokens with text are grouped together after the following comment

        // tokens with text

and before

        // trivia
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 8, 2022
@AlekseyTs
Copy link
Contributor Author

CC @CyrusNajmabadi

@CyrusNajmabadi
Copy link
Member

Seems fine to me. It seems like we'll run out of space there eventually though, so our system needs to be resilient to these ranges not being contiguous. So either way is ok with me. Up to you guys if this is more preferable one way or the other.

@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 18, 2022
@jcouv jcouv self-assigned this Feb 18, 2022
@jcouv jcouv added this to the 17.2 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants