Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSharpAddParameterCheckCodeRefactoringProvider doesn't respect PreferParameterNullChecking #59559

Closed
Youssef1313 opened this issue Feb 15, 2022 · 0 comments · Fixed by #59561
Closed

CSharpAddParameterCheckCodeRefactoringProvider doesn't respect PreferParameterNullChecking #59559

Youssef1313 opened this issue Feb 15, 2022 · 0 comments · Fixed by #59561
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug

Comments

@Youssef1313
Copy link
Member

FYI @RikkiGibson

roslyn/src/Features/CSharp/Portable/InitializeParameter/CSharpAddParameterCheckCodeRefactoringProvider.cs

Lines 108 to 109 in d4440b7

if (!tree.Options.LanguageVersion().IsCSharp11OrAbove())
return null;

This condition should check for the user option.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 15, 2022
@Youssef1313 Youssef1313 mentioned this issue Feb 15, 2022
Merged
@jinujoseph jinujoseph added 4 - In Review A fix for the issue is submitted for review. Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 16, 2022
@jinujoseph jinujoseph added this to the 17.2 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect PreferParameterNullChecking user option Youssef1313/roslyn
2 participants
@jinujoseph @Youssef1313