Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestExecutionQueue fails to dispose of a linked CancellationTokenSource #60649

Closed
sharwell opened this issue Apr 8, 2022 · 0 comments · Fixed by #60653
Closed

RequestExecutionQueue fails to dispose of a linked CancellationTokenSource #60649

sharwell opened this issue Apr 8, 2022 · 0 comments · Fixed by #60653
Assignees
@dibarbet
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@sharwell
Copy link
Member

sharwell commented Apr 8, 2022 •
edited by Pilchie
Loading

The following combined token is never disposed:

roslyn/src/Features/LanguageServer/Protocol/Handler/RequestExecutionQueue.cs

Line 165 in 6023476

var combinedTokenSource = _cancelSource.Token.CombineWith(requestCancellationToken);

This produced a memory leak, where all cancellation token sources for the request queue are retained indefinitely.

Also filed internally:

AB#1495106
AB#1464066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibarbet dibarbet

Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run continuation to dispose of cancellation token source dibarbet/roslyn
2 participants
@sharwell @dibarbet