New APIs for "Primary Constructors"

[AlekseyTs]

Proposed API

namespace Microsoft.CodeAnalysis.CSharp.Syntax
{
     public abstract partial class TypeDeclarationSyntax
     {
+        public ParameterListSyntax? ParameterList { get; }
     }

     public sealed partial class ClassDeclarationSyntax : TypeDeclarationSyntax
     {
+        public new ParameterListSyntax? ParameterList { get; }

+        public ClassDeclarationSyntax WithParameterList(ParameterListSyntax? parameterList);

+        public ClassDeclarationSyntax AddParameterListParameters(params ParameterSyntax[] items);

+        public ClassDeclarationSyntax Update(SyntaxList<AttributeListSyntax> attributeLists, SyntaxTokenList modifiers,
+                                             SyntaxToken keyword, SyntaxToken identifier,
+                                             TypeParameterListSyntax? typeParameterList,
+                                             ParameterListSyntax? parameterList, BaseListSyntax? baseList,
+                                             SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                             SyntaxToken openBraceToken, SyntaxList<MemberDeclarationSyntax> members,
+                                             SyntaxToken closeBraceToken, SyntaxToken semicolonToken);
     }

    public sealed partial class StructDeclarationSyntax : TypeDeclarationSyntax
    {
+        public new ParameterListSyntax? ParameterList { get; }

+        public StructDeclarationSyntax WithParameterList(ParameterListSyntax? parameterList);

+        public StructDeclarationSyntax AddParameterListParameters(params ParameterSyntax[] items);

+        public StructDeclarationSyntax Update(SyntaxList<AttributeListSyntax> attributeLists, SyntaxTokenList modifiers,
+                                              SyntaxToken keyword, SyntaxToken identifier,
+                                              TypeParameterListSyntax? typeParameterList,
+                                              ParameterListSyntax? parameterList, BaseListSyntax? baseList,
+                                              SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                              SyntaxToken openBraceToken, SyntaxList<MemberDeclarationSyntax> members,
+                                              SyntaxToken closeBraceToken, SyntaxToken semicolonToken);
    }

    public static partial class SyntaxFactory
    {
+       public static ClassDeclarationSyntax ClassDeclaration(SyntaxList<AttributeListSyntax> attributeLists,
+                                                             SyntaxTokenList modifiers, SyntaxToken identifier,
+                                                             TypeParameterListSyntax? typeParameterList,
+                                                             ParameterListSyntax? parameterList,
+                                                             BaseListSyntax? baseList,
+                                                             SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                             SyntaxList<MemberDeclarationSyntax> members);

+       public static ClassDeclarationSyntax ClassDeclaration(SyntaxList<AttributeListSyntax> attributeLists,
+                                                             SyntaxTokenList modifiers, SyntaxToken keyword,
+                                                             SyntaxToken identifier,
+                                                             TypeParameterListSyntax? typeParameterList,
+                                                             ParameterListSyntax? parameterList,
+                                                             BaseListSyntax? baseList,
+                                                             SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                             SyntaxToken openBraceToken,
+                                                             SyntaxList<MemberDeclarationSyntax> members,
+                                                             SyntaxToken closeBraceToken, SyntaxToken semicolonToken);

+       public static StructDeclarationSyntax StructDeclaration(SyntaxList<AttributeListSyntax> attributeLists,
+                                                               SyntaxTokenList modifiers, SyntaxToken identifier,
+                                                               TypeParameterListSyntax? typeParameterList,
+                                                               ParameterListSyntax? parameterList,
+                                                               BaseListSyntax? baseList, 
+                                                               SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                               SyntaxList<MemberDeclarationSyntax> members);

+       public static StructDeclarationSyntax StructDeclaration(SyntaxList<AttributeListSyntax> attributeLists,
+                                                               SyntaxTokenList modifiers, SyntaxToken keyword,
+                                                               SyntaxToken identifier,
+                                                               TypeParameterListSyntax? typeParameterList,
+                                                               ParameterListSyntax? parameterList,
+                                                               BaseListSyntax? baseList,
+                                                               SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                               SyntaxToken openBraceToken,
+                                                               SyntaxList<MemberDeclarationSyntax> members,
+                                                               SyntaxToken closeBraceToken,
+                                                               SyntaxToken semicolonToken);
     }
}

[333fred]

API Review

• We may want to move ParameterList up to BaseTypeDeclarationSyntax for error recovery purposes at some point
  • We will confirm that that won't a binary break. Otherwise, this is approved.

[AlekseyTs]

Based on general feedback during API review I made the following changes in #66940:

namespace Microsoft.CodeAnalysis.CSharp.Syntax
{
     public abstract partial class TypeDeclarationSyntax
     {
-        public ParameterListSyntax? ParameterList { get; }
+        public abstract ParameterListSyntax? ParameterList { get; }

+        public TypeDeclarationSyntax WithParameterList(ParameterListSyntax? parameterList);

+        public TypeDeclarationSyntax AddParameterListParameters(params ParameterSyntax[] items);
     }

     public sealed partial class ClassDeclarationSyntax : TypeDeclarationSyntax
     {
-        public new ParameterListSyntax? ParameterList { get; }
+        public override ParameterListSyntax? ParameterList { get; }
     }

     public sealed partial class RecordDeclarationSyntax : TypeDeclarationSyntax
     {
-        public ParameterListSyntax? ParameterList { get; }
+        public override ParameterListSyntax? ParameterList { get; }
     }

    public sealed partial class StructDeclarationSyntax : TypeDeclarationSyntax
    {
-        public new ParameterListSyntax? ParameterList { get; }
+        public override ParameterListSyntax? ParameterList { get; }
    }

     public sealed partial class InterfaceDeclarationSyntax
     {
+        public override ParameterListSyntax? ParameterList { get; }

+        public InterfaceDeclarationSyntax WithParameterList(ParameterListSyntax? parameterList);

+        public InterfaceDeclarationSyntax AddParameterListParameters(params ParameterSyntax[] items);

+        public InterfaceDeclarationSyntax Update(SyntaxList<AttributeListSyntax> attributeLists,
+                                                 SyntaxTokenList modifiers, SyntaxToken keyword,
+                                                 SyntaxToken identifier, TypeParameterListSyntax? typeParameterList,
+                                                 ParameterListSyntax? parameterList, BaseListSyntax? baseList,
+                                                 SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                 SyntaxToken openBraceToken,
+                                                 SyntaxList<MemberDeclarationSyntax> members,
+                                                 SyntaxToken closeBraceToken, SyntaxToken semicolonToken);
     }

    public static partial class SyntaxFactory
    {
+        public static InterfaceDeclarationSyntax InterfaceDeclaration(SyntaxList<AttributeListSyntax> attributeLists,
+                                                                      SyntaxTokenList modifiers, SyntaxToken keyword,
+                                                                      SyntaxToken identifier,
+                                                                      TypeParameterListSyntax? typeParameterList,
+                                                                      ParameterListSyntax? parameterList,
+                                                                      BaseListSyntax? baseList,
+                                                                      SyntaxList<TypeParameterConstraintClauseSyntax> constraintClauses,
+                                                                      SyntaxToken openBraceToken,
+                                                                      SyntaxList<MemberDeclarationSyntax> members,'
+                                                                      SyntaxToken closeBraceToken,
+                                                                      SyntaxToken semicolonToken)
     }
}

[CyrusNajmabadi]

Thanks very much, that is appreciated :)

[333fred]

API Review

Updated definitions are approved.