Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTypeAliases tests are failing in roslyn-ci main #68312

Closed
runfoapp bot opened this issue May 24, 2023 · 11 comments
Closed

TestTypeAliases tests are failing in roslyn-ci main #68312

runfoapp bot opened this issue May 24, 2023 · 11 comments
Assignees
@CyrusNajmabadi
Labels
Area-IDE
Milestone
17.7

Comments

@runfoapp
Copy link

runfoapp bot commented May 24, 2023 •
edited
Loading

Runfo Tracking Issue: TestTypeAliases tests are failing in roslyn-ci main

Build Definition Kind Run Name
297711 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
297711 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296338 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296338 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296080 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296080 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296006 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
296006 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
294710 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
294710 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
293249 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
293249 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
293031 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
293031 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
292994 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
292994 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
292915 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
292915 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291962 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291962 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291961 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291961 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291802 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291802 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291783 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291783 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291587 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
291587 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
289824 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
289824 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
287599 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
287599 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
287064 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
287064 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
286433 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
286433 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
285193 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
285193 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
285086 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
285086 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
284336 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
284336 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
284290 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
284290 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
283851 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
283851 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
283851 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
283851 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
282359 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
282359 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
282337 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
282337 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
281535 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine
281535 roslyn-CI Rolling Test Windows CoreClr Debug Single Machine

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 14 26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 24, 2023
@runfoapp runfoapp bot closed this as completed May 25, 2023
@RikkiGibson RikkiGibson reopened this May 25, 2023
@RikkiGibson
Copy link
Contributor

Here are logs of the failing tests in job Test Windows CoreClr Debug Single Machine. Note that this test only runs on rolling builds, which is why it isn't blocking PRs.

Test log 
  Failed Microsoft.CodeAnalysis.CSharp.UnitTests.PDB.PDBUsingTests.TestTypeAliases3 [147 ms]
  Error Message:
   PDB format: Windows


Expected:
<symbols>
  <files>
    <file id=""1"" name="""" language=""C#"" />
  </files>
  <methods>
    <method containingType=""A"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
        </using>
... truncated ...
Actual:
<symbols>
  <files>
    <file id=""1"" name="""" language=""C#"" />
  </files>
  <methods>
    <method containingType=""A"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""4"" startColumn=""20"" endLine=""4"" endColumn=""21"" document=""1"" />
        <entry offset=""0x1"" startLine=""4"" startColumn=""22"" endLine=""4"" endColumn=""23"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
      </scope>
    </method>
    <method containingType=""X.B"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""10"" startColumn=""24"" endLine=""10"" endColumn=""25"" document=""1"" />
        <entry offset=""0x1"" startLine=""10"" startColumn=""26"" endLine=""10"" endColumn=""27"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
        <currentnamespace name="""" />
      </scope>
    </method>
    <method containingType=""X.Y.C"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""16"" startColumn=""28"" endLine=""16"" endColumn=""29"" document=""1"" />
        <entry offset=""0x1"" startLine=""16"" startColumn=""30"" endLine=""16"" endColumn=""31"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
        <currentnamespace name="""" />
        <currentnamespace name="""" />
      </scope>
    </method>
    <method containingType=""X.Y.X.D"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""22"" startColumn=""32"" endLine=""22"" endColumn=""33"" document=""1"" />
        <entry offset=""0x1"" startLine=""22"" startColumn=""34"" endLine=""22"" endColumn=""35"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
        <currentnamespace name="""" />
        <currentnamespace name="""" />
        <currentnamespace name="""" />
      </scope>
    </method>
  </methods>
</symbols>
Differences:
    <symbols>
      <files>
        <file id=""1"" name="""" language=""C#"" />
      </files>
      <methods>
        <method containingType=""A"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""4"" startColumn=""20"" endLine=""4"" endColumn=""21"" document=""1"" />
            <entry offset=""0x1"" startLine=""4"" startColumn=""22"" endLine=""4"" endColumn=""23"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
-->         <alias name=""P"" target=""System.ValueTuple`2[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51"" kind=""type"" />
          </scope>
        </method>
        <method containingType=""X.B"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""10"" startColumn=""24"" endLine=""10"" endColumn=""25"" document=""1"" />
            <entry offset=""0x1"" startLine=""10"" startColumn=""26"" endLine=""10"" endColumn=""27"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
-->         <alias name=""Q"" target=""System.Int32[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""P"" target=""System.ValueTuple`2[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51"" kind=""type"" />
          </scope>
        </method>
        <method containingType=""X.Y.C"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""16"" startColumn=""28"" endLine=""16"" endColumn=""29"" document=""1"" />
            <entry offset=""0x1"" startLine=""16"" startColumn=""30"" endLine=""16"" endColumn=""31"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
-->         <alias name=""R"" target=""System.Object, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""Q"" target=""System.Int32[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""P"" target=""System.ValueTuple`2[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51"" kind=""type"" />
          </scope>
        </method>
        <method containingType=""X.Y.X.D"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""22"" startColumn=""32"" endLine=""22"" endColumn=""33"" document=""1"" />
            <entry offset=""0x1"" startLine=""22"" startColumn=""34"" endLine=""22"" endColumn=""35"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
-->         <alias name=""S"" target=""System.Int32*, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""R"" target=""System.Object, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""Q"" target=""System.Int32[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""P"" target=""System.ValueTuple`2[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51"" kind=""type"" />
          </scope>
        </method>
      </methods>
    </symbols>

Expected: True
Actual:   False
  Stack Trace:
     at Roslyn.Test.Utilities.AssertEx.Equal[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector, String expectedValueSourcePath, Int32 expectedValueSourceLine) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 241
   at Roslyn.Test.Utilities.AssertEx.AssertLinesEqual(String expected, String actual, String message, String expectedValueSourcePath, Int32 expectedValueSourceLine, Boolean escapeQuotes) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 848
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdbMatchesExpectedXml(Stream peStream, Stream pdbStream, String qualifiedMethodName, PdbToXmlOptions pdbToXmlOptions, String expectedPdb, Int32 expectedValueSourceLine, String expectedValueSourcePath, Boolean expectedIsXmlLiteral, Boolean isPortable) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 309
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.<VerifyPdbImpl>g__Verify|13_0(Boolean isPortable, Boolean testOtherFormat, <>c__DisplayClass13_0&) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 261
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdbImpl(Compilation compilation, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, String qualifiedMethodName, String expectedPdb, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath, Boolean expectedIsXmlLiteral) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 247
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(Compilation compilation, String qualifiedMethodName, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 176
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(Compilation compilation, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 162
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(CompilationVerifier verifier, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 60
   at Microsoft.CodeAnalysis.CSharp.UnitTests.PDB.PDBUsingTests.TestTypeAliases3() in /_/src/Compilers/CSharp/Test/Emit/PDB/PDBUsingTests.cs:line 467
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
  Failed Microsoft.CodeAnalysis.CSharp.UnitTests.PDB.PDBUsingTests.TestTypeAliases1_B [102 ms]
  Error Message:
   PDB format: Windows


Expected:
<symbols>
  <files>
    <file id=""1"" name="""" language=""C#"" />
  </files>
  <methods>
    <method containingType=""A"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
        </using>
... truncated ...
Actual:
<symbols>
  <files>
    <file id=""1"" name="""" language=""C#"" />
  </files>
  <methods>
    <method containingType=""A"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""4"" startColumn=""20"" endLine=""4"" endColumn=""21"" document=""1"" />
        <entry offset=""0x1"" startLine=""4"" startColumn=""22"" endLine=""4"" endColumn=""23"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
      </scope>
    </method>
    <method containingType=""X.B"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""10"" startColumn=""24"" endLine=""10"" endColumn=""25"" document=""1"" />
        <entry offset=""0x1"" startLine=""10"" startColumn=""26"" endLine=""10"" endColumn=""27"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
        <currentnamespace name="""" />
      </scope>
    </method>
    <method containingType=""X.Y.C"" name=""M"">
      <customDebugInfo>
        <using>
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
          <namespace usingCount=""1"" />
        </using>
      </customDebugInfo>
      <sequencePoints>
        <entry offset=""0x0"" startLine=""16"" startColumn=""28"" endLine=""16"" endColumn=""29"" document=""1"" />
        <entry offset=""0x1"" startLine=""16"" startColumn=""30"" endLine=""16"" endColumn=""31"" document=""1"" />
      </sequencePoints>
      <scope startOffset=""0x0"" endOffset=""0x2"">
        <currentnamespace name="""" />
        <currentnamespace name="""" />
        <currentnamespace name="""" />
      </scope>
    </method>
  </methods>
</symbols>
Differences:
    <symbols>
      <files>
        <file id=""1"" name="""" language=""C#"" />
      </files>
      <methods>
        <method containingType=""A"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""4"" startColumn=""20"" endLine=""4"" endColumn=""21"" document=""1"" />
            <entry offset=""0x1"" startLine=""4"" startColumn=""22"" endLine=""4"" endColumn=""23"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
-->         <alias name=""P"" target=""System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
          </scope>
        </method>
        <method containingType=""X.B"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""10"" startColumn=""24"" endLine=""10"" endColumn=""25"" document=""1"" />
            <entry offset=""0x1"" startLine=""10"" startColumn=""26"" endLine=""10"" endColumn=""27"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
-->         <alias name=""Q"" target=""System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""P"" target=""System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
          </scope>
        </method>
        <method containingType=""X.Y.C"" name=""M"">
          <customDebugInfo>
            <using>
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
              <namespace usingCount=""1"" />
            </using>
          </customDebugInfo>
          <sequencePoints>
            <entry offset=""0x0"" startLine=""16"" startColumn=""28"" endLine=""16"" endColumn=""29"" document=""1"" />
            <entry offset=""0x1"" startLine=""16"" startColumn=""30"" endLine=""16"" endColumn=""31"" document=""1"" />
          </sequencePoints>
          <scope startOffset=""0x0"" endOffset=""0x2"">
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
++>         <currentnamespace name="""" />
-->         <alias name=""R"" target=""System.Char, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""Q"" target=""System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
-->         <alias name=""P"" target=""System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"" kind=""type"" />
          </scope>
        </method>
      </methods>
    </symbols>

Expected: True
Actual:   False
  Stack Trace:
     at Roslyn.Test.Utilities.AssertEx.Equal[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector, String expectedValueSourcePath, Int32 expectedValueSourceLine) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 241
   at Roslyn.Test.Utilities.AssertEx.AssertLinesEqual(String expected, String actual, String message, String expectedValueSourcePath, Int32 expectedValueSourceLine, Boolean escapeQuotes) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 848
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdbMatchesExpectedXml(Stream peStream, Stream pdbStream, String qualifiedMethodName, PdbToXmlOptions pdbToXmlOptions, String expectedPdb, Int32 expectedValueSourceLine, String expectedValueSourcePath, Boolean expectedIsXmlLiteral, Boolean isPortable) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 309
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.<VerifyPdbImpl>g__Verify|13_0(Boolean isPortable, Boolean testOtherFormat, <>c__DisplayClass13_0&) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 261
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdbImpl(Compilation compilation, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, String qualifiedMethodName, String expectedPdb, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath, Boolean expectedIsXmlLiteral) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 247
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(Compilation compilation, String qualifiedMethodName, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 176
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(Compilation compilation, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 162
   at Microsoft.CodeAnalysis.Test.Utilities.PdbValidation.VerifyPdb(CompilationVerifier verifier, String expectedPdb, IEnumerable`1 embeddedTexts, IMethodSymbol debugEntryPoint, DebugInformationFormat format, PdbValidationOptions options, Int32 expectedValueSourceLine, String expectedValueSourcePath) in /_/src/Test/PdbUtilities/Reader/PdbValidation.cs:line 60
   at Microsoft.CodeAnalysis.CSharp.UnitTests.PDB.PDBUsingTests.TestTypeAliases1_B() in /_/src/Compilers/CSharp/Test/Emit/PDB/PDBUsingTests.cs:line 300
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

It seems like some aliases which were expected to be included in the PDB are no longer being included. @CyrusNajmabadi it looks like you may have updated the affected tests most recently. Any insight into what may be happening?

roslyn/src/Compilers/CSharp/Test/Emit/PDB/PDBUsingTests.cs

Line 439 in ec5bd43

public void TestTypeAliases3()

roslyn/src/Compilers/CSharp/Test/Emit/PDB/PDBUsingTests.cs

Line 279 in ec5bd43

public void TestTypeAliases1_B()

@jaredpar
Copy link
Member

@RikkiGibson

Note that this test only runs on rolling builds, which is why it isn't blocking PRs.

This runs on PRs. Example is this AzDO build. You can see by setting the filters.

image

This specific configuration though is CI only. Basically when we build and test on the same machine (no helix). That is very odd that it's failing only in that configuration and not in the Helix one.

@jaredpar
Copy link
Member

Good news though is @CyrusNajmabadi should be able to reproduce this locally 😄

@RikkiGibson
Copy link
Contributor

I said test when I meant to say job, sorry.

@jaredpar
Copy link
Member

jaredpar commented Jun 1, 2023

In chatting with @CyrusNajmabadi my suspicion would be on #67105

@CyrusNajmabadi
Copy link
Member

@tmat Do you have any idea why this would be non-deterministic. The only code added for PDB work was the minor change in #67105. But i don't understand enough of hte subsystem that code exists in to have any idea why it woudl sometimes create some PDB results and sometimes others.

@CyrusNajmabadi CyrusNajmabadi mentioned this issue Jun 7, 2023
Merged
@tmat
Copy link
Member

tmat commented Jun 7, 2023

I'd be fine if we remove testing of Windows PDBs for this feature (which is likely causing the non-deterministic behavior).

@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 7, 2023
@jasonmalinowski
Copy link
Member

Assigning to @jaredpar just because he's already got a PR out for it.

@jaredpar
Copy link
Member

jaredpar commented Jun 7, 2023

@jasonmalinowski

I don't have a PR out to fix this. Only thing I have out is about Macs. @CyrusNajmabadi has one out that disables the tests but doesn't fix the underlying issue.

This is a product bug, not a test issue by all the evidence we see. This seemingly dates back to #25737 (thanks @CyrusNajmabadi for tracking that down). If it is a Windows PDB issue we should be filing a bug on the Windows DIA layer and adjusting our tests to not test using native PDBs. Just ignoring it doesn't seem like the right thing.

@jaredpar jaredpar added this to the 17.7 milestone Jun 7, 2023
@jasonmalinowski
Copy link
Member

@jaredpar: oops, my bad.

@CyrusNajmabadi
Copy link
Member

Skipped with #68468. Being tracked overall with #25737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE
Projects
None yet
Milestone
17.7
Development

No branches or pull requests
5 participants
@tmat @jaredpar @jasonmalinowski @CyrusNajmabadi @RikkiGibson