Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use background work indicator for Go To Definition #69389

Closed
Tracked by #61416
sharwell opened this issue Aug 4, 2023 · 3 comments
Closed
Tracked by #61416

Use background work indicator for Go To Definition #69389

sharwell opened this issue Aug 4, 2023 · 3 comments
Assignees
@CyrusNajmabadi
Labels
Area-IDE IDE-Navigation Navigation and search
Milestone
17.3

Comments

@sharwell
Copy link
Member

sharwell commented Aug 4, 2023

No description provided.

@sharwell sharwell mentioned this issue Aug 4, 2023
Open
3 tasks
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 4, 2023
@arunchndr arunchndr added the IDE-Navigation Navigation and search label Aug 4, 2023
@arunchndr arunchndr added this to the 18.0 milestone Aug 4, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 4, 2023
@CyrusNajmabadi
Copy link
Member

Goto def already does this:

roslyn/src/EditorFeatures/Core/GoToDefinition/GoToDefinitionCommandHandler.cs

Lines 171 to 174 in e0ea426

using (var backgroundIndicator = indicatorFactory.Create(
args.TextView, applicableToSpan,
EditorFeaturesResources.Navigating_to_definition))
{

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
@sharwell
Copy link
Member Author

Closing as completed (was implemented in #59759)

@sharwell sharwell modified the milestones: 18.0, 17.3 Jan 30, 2024
@sharwell
Copy link
Member Author

Enabled by default in #71018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE IDE-Navigation Navigation and search
Projects
None yet
Milestone
17.3
Development

No branches or pull requests
3 participants
@sharwell @CyrusNajmabadi @arunchndr