Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions: rectify ctor check in conversions #70182

Closed
jcouv opened this issue Sep 28, 2023 · 1 comment
Closed

Collection expressions: rectify ctor check in conversions #70182

jcouv opened this issue Sep 28, 2023 · 1 comment
Assignees
@jcouv
Labels
Area-Compilers Bug New Feature - Collection Expressions
Milestone
17.9

Comments

@jcouv
Copy link
Member

jcouv commented Sep 28, 2023 •
edited
Loading

The logic in GetCollectionExpressionConversion needs to be rectified to either:

  1. keep binding to the constructor, but separate use-site errors
  2. use specific lookup rules to find the constructor, instead of binding to the constructor
  3. drop constructor check (as proposed here, but needs a decision from LDM)

This issue is referenced in source.

Relates to PR #69956
Relates to test plan #66418
@jcouv jcouv added this to the 17.9 milestone Sep 28, 2023
@jcouv jcouv self-assigned this Sep 28, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 28, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 28, 2023
@jcouv
Copy link
Member Author

jcouv commented Oct 3, 2023

This can be closed, as the binding checks are now being removed from conversions.

@jcouv jcouv closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Bug New Feature - Collection Expressions
Projects
None yet
Milestone
17.9
Development

No branches or pull requests
1 participant
@jcouv