Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WellKnownMember.System_String__Format_IFormatProvider should actually be a SpecialMember #72280

Closed
AlekseyTs opened this issue Feb 27, 2024 · 1 comment · Fixed by #72646
Closed

WellKnownMember.System_String__Format_IFormatProvider should actually be a SpecialMember #72280

AlekseyTs opened this issue Feb 27, 2024 · 1 comment · Fixed by #72646
Assignees
@AlekseyTs
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Milestone
17.10

Comments

@AlekseyTs
Copy link
Contributor

The string type must come from the core library, therefore, it's method should also come from the same library.
It looks like the only reference that we have for WellKnownType.System_IFormatProvider is the signature specification for WellKnownMember.System_String__Format_IFormatProvider, so we should simply move it to the SpecialType set. The rest of the types used in the signature are special types already.
@AlekseyTs AlekseyTs added Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers labels Feb 27, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 27, 2024
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 12, 2024
@jaredpar jaredpar added this to the 17.10 milestone Mar 12, 2024
@AlekseyTs
Copy link
Contributor Author

I am going to take care of this issue under umbrella of #72102

@AlekseyTs AlekseyTs assigned AlekseyTs and unassigned jjonescz Mar 19, 2024
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Mar 21, 2024
@AlekseyTs
Introduce a concept of internal special types, move all members defin…
830bdd2 
…ed in special types to the SpecialMember set.

Closes dotnet#72102.
Closes dotnet#72280.
@AlekseyTs AlekseyTs mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API.
Projects
None yet
Milestone
17.10
3 participants
@jaredpar @jjonescz @AlekseyTs