Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBuiltInAnalyzer.OpenFileOnly #74048

Closed
tmat opened this issue Jun 18, 2024 · 2 comments
Closed

Remove IBuiltInAnalyzer.OpenFileOnly #74048

tmat opened this issue Jun 18, 2024 · 2 comments

Comments

@tmat
Copy link
Member

tmat commented Jun 18, 2024

Used to limit certain analyzers to open files only, based on options that affect the analysis.
We use global values of editorconfig options to determine whether or not to enable analysis for open docs.
The actual values of these options can be set in editorconfig files and vary file by file.

Seems like these analyzers should just respond to pull diagnostics and we should remove this check.

Non-trivial implementations:

  • SimplifyTypeNamesDiagnosticAnalyzerBase
  • PreferFrameworkTypeDiagnosticAnalyzerBase
  • AbstractQualifyMemberAccessDiagnosticAnalyzer
  • CSharpTypeStyleDiagnosticAnalyzerBase

Tracks TODO in code.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 18, 2024
@tmat tmat added the Area-IDE label Jun 18, 2024
@Cosifne Cosifne removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 2, 2024
@CyrusNajmabadi CyrusNajmabadi self-assigned this Jul 10, 2024
@CyrusNajmabadi
Copy link
Member

i'm going to try to do this.

@CyrusNajmabadi
Copy link
Member

Fixed with #74340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants