Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGetFixesWithDeprioritizedAnalyzerAsync tests a scenario that cannot be reached #77036

Open
CyrusNajmabadi opened this issue Feb 4, 2025 · 0 comments
Labels
Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@CyrusNajmabadi
Copy link
Member

This test validates some sort of analyzer deprioritization system. However the test works by explicitly calling into a test accessor and mutating state that cannot be mutated by normal workspace operations. Specifically, it calls into DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs TextDocumentOpenAsync

private async Task TextDocumentOpenAsync(TextDocument document, CancellationToken cancellationToken)
, which is not hit by any actual product code.

Found in #74984

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

No branches or pull requests

1 participant