Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: Invoking rename when there is an active session should commit #44

Closed
Pilchie opened this issue Jan 20, 2015 · 10 comments
Closed

Comments

@Pilchie
Copy link
Member

Pilchie commented Jan 20, 2015

No description provided.

@Pilchie Pilchie added this to the 1.1 milestone Jan 20, 2015
@DustinCampbell
Copy link
Member

Yes it should. 😄

@balajikris
Copy link
Member

Looks like our current design sets the focus to the dashboard in such a scenario.

the command handler has a comment and a piece of code to do this:
// If there is already an active session, focus its dashboard;

@DustinCampbell
Copy link
Member

I remember now. We changed F2 to focus the dashboard to provide keyboard access to various checkboxes. Now that I try that experience, I think that might not be the right behavior. In order to keep users fluid productive, I think F2 should probably commit the active session and start a new one. @Pilchie, what do you think?

If we change this back, are users still able to use the options on the dashboard with the keyword? Using accelerator keys should still work, right?

@Pilchie
Copy link
Member Author

Pilchie commented Jan 21, 2015

@rchande - do you know the state of accelerators and F2?

@rchande
Copy link
Contributor

rchande commented Jan 21, 2015

Accelerators should work even if you focus the editor. We changed F2 to refocus the dashboard in order to allow users of screen readers to have the dashboard read to them. How could we implement that if we made F2 commit?

@DustinCampbell
Copy link
Member

What if we had a separate accelerator key that could provide focus without invoking a particular UI element. Is that possible?

@rchande
Copy link
Contributor

rchande commented Jan 21, 2015

Sure, that sounds reasonable.

@basoundr basoundr assigned basoundr and dpoeschl and unassigned dpoeschl and basoundr Jan 22, 2015
@dpoeschl dpoeschl assigned rchande and unassigned dpoeschl Jan 22, 2015
@Pilchie Pilchie modified the milestones: 1.0 (stable), 1.1 Feb 3, 2015
@rchande
Copy link
Contributor

rchande commented May 21, 2015

The new plan here is:

The dashboard isn't focused by default. F2 within a rename field focuses it, F2 outside a rename field commits and tries to start a new session.

@rchande
Copy link
Contributor

rchande commented Jun 1, 2015

Merged into stabilization with #3186.

@rchande
Copy link
Contributor

rchande commented Jun 5, 2015

@Pilchie Can you verify this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants