From 1b1246643bd12635207ca27b2f6ffc7989b2fb9e Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 18 Jun 2020 13:40:57 +0200 Subject: [PATCH 01/20] Remove IDE0044 suppression --- src/Workspaces/Core/Portable/Options/GlobalOptionService.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs index 7293a0d606a71..2224d1c4b355a 100644 --- a/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs +++ b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs @@ -32,11 +32,9 @@ internal class GlobalOptionService : IGlobalOptionService private readonly object _gate = new object(); -#pragma warning disable IDE0044 // Add readonly modifier - https://github.com/dotnet/roslyn/issues/33009 private ImmutableDictionary _neutralEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; private ImmutableDictionary _csharpEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; private ImmutableDictionary _visualBasicEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; -#pragma warning restore IDE0044 // Add readonly modifier private ImmutableDictionary _currentValues; private ImmutableHashSet _changedOptionKeys; From eeba605d699fa82ec066971e86f817a16a2faf84 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 18 Jun 2020 17:36:56 +0200 Subject: [PATCH 02/20] Update Versions.props --- eng/Versions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index 1325209484509..a5223fd399a7e 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,7 +31,7 @@ 3.3.0-beta1.20305.4 3.6.0-2.final 1.0.1-beta1.20210.2 - 3.7.0-3.20271.4 + 3.7.0-2.20277.1 16.4.248 5.0.0-alpha1.19409.1 16.7.29 From 2df5ecd07d59c12133b07f2e412b77d755b37c90 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 18 Jun 2020 17:57:54 +0200 Subject: [PATCH 03/20] Update Versions.props --- eng/Versions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index a5223fd399a7e..4be57853a10c1 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,7 +31,7 @@ 3.3.0-beta1.20305.4 3.6.0-2.final 1.0.1-beta1.20210.2 - 3.7.0-2.20277.1 + 3.8.0-1.20318.7 16.4.248 5.0.0-alpha1.19409.1 16.7.29 From 68ef1f3687d3d7f48935d346b42c5a6e943c75b3 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Sat, 20 Jun 2020 20:44:40 +0200 Subject: [PATCH 04/20] try to use latest dotnet-format version --- dotnet-tools.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dotnet-tools.json b/dotnet-tools.json index d81bfe9ae6d99..809b31fadcd82 100644 --- a/dotnet-tools.json +++ b/dotnet-tools.json @@ -2,7 +2,7 @@ "isRoot": true, "tools": { "dotnet-format": { - "version": "4.0.130203", + "version": "4.1.131201", "commands": [ "dotnet-format" ] @@ -14,4 +14,4 @@ ] } } -} \ No newline at end of file +} From c77baa05fdcb5d3768a59fcd9a1450b8f79c92e9 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Mon, 20 Jul 2020 21:47:12 +0200 Subject: [PATCH 05/20] Update Versions.props --- eng/Versions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index 2c7f6622ae35e..f1fe549687a77 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,7 +31,7 @@ 3.3.0-beta1.20352.4 3.6.0-2.final 1.0.1-beta1.20358.1 - 3.7.0-3.20271.4 + 3.8.0-1.20330.5 16.4.248 5.0.0-alpha1.19409.1 16.8.5 From a7d28bc56cac00d148d0098014e3bf0c312d84c1 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Tue, 21 Jul 2020 05:41:49 +0200 Subject: [PATCH 06/20] Update dotnet-tools.json --- dotnet-tools.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotnet-tools.json b/dotnet-tools.json index 809b31fadcd82..5b5e2747f3817 100644 --- a/dotnet-tools.json +++ b/dotnet-tools.json @@ -2,7 +2,7 @@ "isRoot": true, "tools": { "dotnet-format": { - "version": "4.1.131201", + "version": "5.0.137002", "commands": [ "dotnet-format" ] From 5e9789951156ee25c490b95144441abd4efd044f Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Tue, 21 Jul 2020 05:42:38 +0200 Subject: [PATCH 07/20] Update Versions.props --- eng/Versions.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Versions.props b/eng/Versions.props index f1fe549687a77..dc13bb2d83d2f 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,7 +31,7 @@ 3.3.0-beta1.20352.4 3.6.0-2.final 1.0.1-beta1.20358.1 - 3.8.0-1.20330.5 + 3.8.0-1.20367.11 16.4.248 5.0.0-alpha1.19409.1 16.8.5 From 4f35deee309600e06cc14401691998348aaeacbb Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Sat, 8 Aug 2020 05:37:21 +0200 Subject: [PATCH 08/20] Apply suggestions from code review Co-authored-by: Joey Robichaud --- dotnet-tools.json | 2 +- eng/Versions.props | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dotnet-tools.json b/dotnet-tools.json index 5b5e2747f3817..81119b32e4f17 100644 --- a/dotnet-tools.json +++ b/dotnet-tools.json @@ -2,7 +2,7 @@ "isRoot": true, "tools": { "dotnet-format": { - "version": "5.0.137002", + "version": "5.0.140801", "commands": [ "dotnet-format" ] diff --git a/eng/Versions.props b/eng/Versions.props index 5ac2d8f0a9c32..ddfeada44f0f8 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,7 +31,7 @@ 3.3.0-beta1.20352.4 3.6.0-2.final 1.0.1-beta1.20378.2 - 3.8.0-1.20367.11 + 3.8.0-2.20407.3 16.4.248 5.0.0-alpha1.19409.1 16.8.5 @@ -274,4 +274,4 @@ --> true - \ No newline at end of file + From f8b394bfcc972a2abed29effac949479c2a46d65 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Sat, 8 Aug 2020 10:50:15 +0200 Subject: [PATCH 09/20] Try to fix IDE0055 --- .../SymbolDisplay/SymbolDisplayVisitor.Types.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs b/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs index fda4e4baa458c..b7055458b7996 100644 --- a/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs +++ b/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs @@ -716,12 +716,12 @@ private static IMethodSymbol FindValidCloneMethod(ITypeSymbol containingType) foreach (var member in containingType.GetMembers(WellKnownMemberNames.CloneMethodName)) { if (member is IMethodSymbol - { - DeclaredAccessibility: Accessibility.Public, - IsStatic: false, - Parameters: { Length: 0 }, - Arity: 0 - } method) + { + DeclaredAccessibility: Accessibility.Public, + IsStatic: false, + Parameters: { Length: 0 }, + Arity: 0 + } method) { if (candidate is object) { From 475d34533f8540e4e219063d4086c08e57ca7a7d Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Sat, 8 Aug 2020 19:39:04 +0200 Subject: [PATCH 10/20] Update SynthesizedRecordClone.cs --- .../Synthesized/Records/SynthesizedRecordClone.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs b/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs index 556395778dd94..3e6adde43806c 100644 --- a/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs +++ b/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs @@ -155,12 +155,12 @@ internal override void GenerateMethodBody(TypeCompilationState compilationState, foreach (var member in containingType.GetMembers(WellKnownMemberNames.CloneMethodName)) { if (member is MethodSymbol - { - DeclaredAccessibility: Accessibility.Public, - IsStatic: false, - ParameterCount: 0, - Arity: 0 - } method) + { + DeclaredAccessibility: Accessibility.Public, + IsStatic: false, + ParameterCount: 0, + Arity: 0 + } method) { if (candidate is object) { From 8fd7767053bb0d669a65603ba891e3f7323dc2f4 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Sat, 8 Aug 2020 20:05:09 +0200 Subject: [PATCH 11/20] Update CSharpMethodExtractor.CSharpCodeGenerator.cs --- .../CSharpMethodExtractor.CSharpCodeGenerator.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs b/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs index cc0d8efbd157a..f987f6d2661d8 100644 --- a/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs +++ b/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs @@ -597,10 +597,10 @@ protected override ExpressionSyntax CreateCallSignature() if (CSharpSelectionResult.ShouldCallConfigureAwaitFalse()) { if (AnalyzerResult.ReturnType.GetMembers().Any(x => x is IMethodSymbol - { - Name: nameof(Task.ConfigureAwait), - Parameters: { Length: 1 } parameters - } && parameters[0].Type.SpecialType == SpecialType.System_Boolean)) + { + Name: nameof(Task.ConfigureAwait), + Parameters: { Length: 1 } parameters + } && parameters[0].Type.SpecialType == SpecialType.System_Boolean)) { invocation = SyntaxFactory.InvocationExpression( SyntaxFactory.MemberAccessExpression( From 488e2ac7f6d1ba471030fe366b664a27409e95c2 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Mon, 10 Aug 2020 20:34:31 +0200 Subject: [PATCH 12/20] Update MakeFieldReadonlyTests.cs --- .../MakeFieldReadonly/MakeFieldReadonlyTests.cs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs index b6cff758fff1a..60c43bea08407 100644 --- a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs +++ b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs @@ -1705,6 +1705,23 @@ await TestInRegularAndScript1Async( { private volatile object first; private readonly object second; +}"); + } + + [WorkItem(45288, "https://github.com/dotnet/roslyn/pull/45288")] + [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] + public async Task UsedAsRef_NoDiagnostic() + { + await TestMissingInRegularAndScriptAsync( +@"public class C +{ + private string [|_x|] = string.Empty; + + public bool M() + { + ref var myVar = ref x; + return myVar is null; + } }"); } } From 617ea328a728325edc8775b337640cb433638e5f Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 13 Aug 2020 18:24:13 +0200 Subject: [PATCH 13/20] Skip failing test --- .../CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs index 60c43bea08407..6ea1c8812c001 100644 --- a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs +++ b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs @@ -1709,7 +1709,7 @@ await TestInRegularAndScript1Async( } [WorkItem(45288, "https://github.com/dotnet/roslyn/pull/45288")] - [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] + [Fact(Skip = "https://github.com/dotnet/roslyn/issues/33009"), Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] public async Task UsedAsRef_NoDiagnostic() { await TestMissingInRegularAndScriptAsync( From ddea1321335cb28e2aa360a357914005bc30314f Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 13 Aug 2020 18:26:21 +0200 Subject: [PATCH 14/20] Add suppression back --- src/Workspaces/Core/Portable/Options/GlobalOptionService.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs index 86c8e4bf151ec..784b5375ef03c 100644 --- a/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs +++ b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs @@ -34,9 +34,11 @@ internal class GlobalOptionService : IGlobalOptionService private readonly object _gate = new object(); +#pragma warning disable IDE0044 // Add readonly modifier - https://github.com/dotnet/roslyn/issues/33009 private ImmutableDictionary _neutralEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; private ImmutableDictionary _csharpEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; private ImmutableDictionary _visualBasicEditorConfigKeysToOptions = s_emptyEditorConfigKeysToOptions; +#pragma warning restore IDE0044 // Add readonly modifier private ImmutableDictionary _currentValues; private ImmutableHashSet _changedOptionKeys; From 41b885cca35c4cbc2f28c1aef731fd269331f9d6 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 13 Aug 2020 18:29:01 +0200 Subject: [PATCH 15/20] Update dotnet-tools.json --- dotnet-tools.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotnet-tools.json b/dotnet-tools.json index 81119b32e4f17..c6a27a88ac606 100644 --- a/dotnet-tools.json +++ b/dotnet-tools.json @@ -2,7 +2,7 @@ "isRoot": true, "tools": { "dotnet-format": { - "version": "5.0.140801", + "version": "4.0.130203", "commands": [ "dotnet-format" ] From 6a3d4fcdee42abf7ea683eff350512c03bdc0c12 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 13 Aug 2020 18:40:18 +0200 Subject: [PATCH 16/20] Update WorkItem --- .../CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs index 6ea1c8812c001..96f6344120d7e 100644 --- a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs +++ b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs @@ -1708,7 +1708,7 @@ await TestInRegularAndScript1Async( }"); } - [WorkItem(45288, "https://github.com/dotnet/roslyn/pull/45288")] + [WorkItem(33009, "https://github.com/dotnet/roslyn/issues/33009")] [Fact(Skip = "https://github.com/dotnet/roslyn/issues/33009"), Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] public async Task UsedAsRef_NoDiagnostic() { From 3e670bcb6e75310665e4498139370796a814265a Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Thu, 13 Aug 2020 18:44:02 +0200 Subject: [PATCH 17/20] Update MakeFieldReadonlyTests.cs --- .../CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs index 96f6344120d7e..214b33631ba97 100644 --- a/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs +++ b/src/Analyzers/CSharp/Tests/MakeFieldReadonly/MakeFieldReadonlyTests.cs @@ -1708,8 +1708,8 @@ await TestInRegularAndScript1Async( }"); } - [WorkItem(33009, "https://github.com/dotnet/roslyn/issues/33009")] - [Fact(Skip = "https://github.com/dotnet/roslyn/issues/33009"), Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] + [WorkItem(46785, "https://github.com/dotnet/roslyn/issues/46785")] + [Fact(Skip = "https://github.com/dotnet/roslyn/issues/46785"), Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)] public async Task UsedAsRef_NoDiagnostic() { await TestMissingInRegularAndScriptAsync( From 559f63025621b047a246195d67fcc3be3a3b2f60 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Wed, 26 Aug 2020 17:11:14 +0200 Subject: [PATCH 18/20] Undo indentation --- .../SymbolDisplay/SymbolDisplayVisitor.Types.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs b/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs index b7055458b7996..fda4e4baa458c 100644 --- a/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs +++ b/src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs @@ -716,12 +716,12 @@ private static IMethodSymbol FindValidCloneMethod(ITypeSymbol containingType) foreach (var member in containingType.GetMembers(WellKnownMemberNames.CloneMethodName)) { if (member is IMethodSymbol - { - DeclaredAccessibility: Accessibility.Public, - IsStatic: false, - Parameters: { Length: 0 }, - Arity: 0 - } method) + { + DeclaredAccessibility: Accessibility.Public, + IsStatic: false, + Parameters: { Length: 0 }, + Arity: 0 + } method) { if (candidate is object) { From b420bea04163a075f812a4a4a27e130f7734962e Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Wed, 26 Aug 2020 17:11:38 +0200 Subject: [PATCH 19/20] Undo indentation --- .../Synthesized/Records/SynthesizedRecordClone.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs b/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs index 3e6adde43806c..556395778dd94 100644 --- a/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs +++ b/src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordClone.cs @@ -155,12 +155,12 @@ internal override void GenerateMethodBody(TypeCompilationState compilationState, foreach (var member in containingType.GetMembers(WellKnownMemberNames.CloneMethodName)) { if (member is MethodSymbol - { - DeclaredAccessibility: Accessibility.Public, - IsStatic: false, - ParameterCount: 0, - Arity: 0 - } method) + { + DeclaredAccessibility: Accessibility.Public, + IsStatic: false, + ParameterCount: 0, + Arity: 0 + } method) { if (candidate is object) { From da75fa00f9d093b10f3e4db900d3216f7c49a3b1 Mon Sep 17 00:00:00 2001 From: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Wed, 26 Aug 2020 17:12:19 +0200 Subject: [PATCH 20/20] Undo indentation --- .../CSharpMethodExtractor.CSharpCodeGenerator.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs b/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs index f987f6d2661d8..cc0d8efbd157a 100644 --- a/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs +++ b/src/Features/CSharp/Portable/ExtractMethod/CSharpMethodExtractor.CSharpCodeGenerator.cs @@ -597,10 +597,10 @@ protected override ExpressionSyntax CreateCallSignature() if (CSharpSelectionResult.ShouldCallConfigureAwaitFalse()) { if (AnalyzerResult.ReturnType.GetMembers().Any(x => x is IMethodSymbol - { - Name: nameof(Task.ConfigureAwait), - Parameters: { Length: 1 } parameters - } && parameters[0].Type.SpecialType == SpecialType.System_Boolean)) + { + Name: nameof(Task.ConfigureAwait), + Parameters: { Length: 1 } parameters + } && parameters[0].Type.SpecialType == SpecialType.System_Boolean)) { invocation = SyntaxFactory.InvocationExpression( SyntaxFactory.MemberAccessExpression(