Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roslyn implementation of error list #62741

Merged
merged 59 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
203cd3d
Remove roslyn implementation of error list
CyrusNajmabadi Jul 18, 2022
d35de28
REmove files
CyrusNajmabadi Jul 18, 2022
03ef6ff
REmove files
CyrusNajmabadi Jul 18, 2022
8bda2e9
Remove listener
CyrusNajmabadi Jul 18, 2022
4cdc2e3
Simplify
CyrusNajmabadi Jul 18, 2022
f26e55f
Remove unused field
CyrusNajmabadi Jul 19, 2022
fb575a2
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Aug 3, 2022
c08976b
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Aug 23, 2022
4f0fc19
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Sep 1, 2022
190e467
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Sep 12, 2022
e242d51
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Sep 15, 2022
85a0e0b
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Sep 16, 2022
f459d13
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Sep 28, 2022
fb21b48
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Oct 21, 2022
d8f9a31
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Nov 9, 2022
d80581a
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Dec 15, 2022
3ba9349
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Feb 8, 2023
82456eb
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 10, 2023
fcf9c19
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Mar 19, 2023
76deff4
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Mar 27, 2023
7688a63
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Jul 18, 2023
6dabc7f
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Aug 22, 2023
7f89cdd
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Oct 24, 2023
8091466
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Oct 25, 2023
81062bf
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Oct 26, 2023
fe906a3
Merge branch 'DisableTests' into errorListRemoval
CyrusNajmabadi Oct 26, 2023
c064c3d
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Nov 20, 2023
eb8edde
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Dec 11, 2023
e1a1984
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Dec 18, 2023
a45e35b
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Dec 21, 2023
31be6ce
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Jan 14, 2024
4393375
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Jan 29, 2024
ec0f7fa
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 2, 2024
a2d4636
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 5, 2024
e838819
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 7, 2024
15a0f02
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 8, 2024
79c644f
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 8, 2024
2f7d8d5
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Feb 9, 2024
62dbb23
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 12, 2024
59f0c4e
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 21, 2024
dfb9d05
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 22, 2024
f89e195
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 24, 2024
7f7e0da
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 26, 2024
1453401
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Feb 26, 2024
91988c4
Merge branch 'errorListRemoval' of https://github.com/CyrusNajmabadi/…
CyrusNajmabadi Feb 26, 2024
5fa5152
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Feb 28, 2024
6ab104b
Merge branch 'main' into errorListRemoval
CyrusNajmabadi Mar 5, 2024
b577e00
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 6, 2024
649fccf
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 6, 2024
013d797
Fix test
CyrusNajmabadi Mar 6, 2024
95c5fd7
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Mar 6, 2024
69898f4
Add assertion info
CyrusNajmabadi Mar 6, 2024
70eff23
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 6, 2024
2a5b65a
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 6, 2024
a2d8455
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 7, 2024
2f12159
Coordinate
CyrusNajmabadi Mar 7, 2024
bda523c
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 7, 2024
f20fa37
Merge branch 'removePushDiagnostics' into errorListRemoval
CyrusNajmabadi Mar 7, 2024
9df875d
Merge remote-tracking branch 'upstream/main' into errorListRemoval
CyrusNajmabadi Mar 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ private static DiagnosticService GetDiagnosticService(TestWorkspace workspace)
{
var diagnosticService = Assert.IsType<DiagnosticService>(workspace.ExportProvider.GetExportedValue<IDiagnosticService>());

// These tests were originally written under the assumption that the diagnostic service will not be
// initialized with listeners. If this check ever fails, the tests that use this method should be reviewed
// for impact.
Assert.Empty(diagnosticService.GetTestAccessor().EventListenerTracker.GetTestAccessor().EventListeners);

return diagnosticService;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ internal partial class DiagnosticService : IDiagnosticService
private readonly object _gate = new();
private readonly Dictionary<IDiagnosticUpdateSource, Dictionary<Workspace, Dictionary<object, Data>>> _map = [];

private readonly EventListenerTracker<IDiagnosticService> _eventListenerTracker;

private ImmutableHashSet<IDiagnosticUpdateSource> _updateSources;

[ImportingConstructor]
Expand All @@ -42,14 +40,12 @@ public DiagnosticService(
[ImportMany] IEnumerable<Lazy<IEventListener, EventListenerMetadata>> eventListeners)
{
// we use registry service rather than doing MEF import since MEF import method can have race issue where
// update source gets created before aggregator - diagnostic service - is created and we will lose events fired before
// the aggregator is created.
// update source gets created before aggregator - diagnostic service - is created and we will lose events
// fired before the aggregator is created.
_updateSources = [];

// queue to serialize events.
_eventQueue = new TaskQueue(listenerProvider.GetListener(FeatureAttribute.DiagnosticService), TaskScheduler.Default);

_eventListenerTracker = new EventListenerTracker<IDiagnosticService>(eventListeners, WellKnownEventListeners.DiagnosticService);
}

public event EventHandler<ImmutableArray<DiagnosticsUpdatedArgs>> DiagnosticsUpdated
Expand All @@ -67,16 +63,6 @@ public event EventHandler<ImmutableArray<DiagnosticsUpdatedArgs>> DiagnosticsUpd

private void RaiseDiagnosticsUpdated(IDiagnosticUpdateSource source, ImmutableArray<DiagnosticsUpdatedArgs> argsCollection)
{
Workspace? previousWorkspace = null;
foreach (var args in argsCollection)
{
if (args.Workspace != previousWorkspace)
{
_eventListenerTracker.EnsureEventListener(args.Workspace, this);
previousWorkspace = args.Workspace;
}
}

var ev = _eventMap.GetEventHandlers<EventHandler<ImmutableArray<DiagnosticsUpdatedArgs>>>(DiagnosticsUpdatedEventName);

_eventQueue.ScheduleTask(DiagnosticsUpdatedEventName, () =>
Expand Down Expand Up @@ -415,19 +401,5 @@ public Data(UpdatedEventArgs args, ImmutableArray<DiagnosticData> diagnostics)
Diagnostics = diagnostics;
}
}

internal TestAccessor GetTestAccessor()
=> new(this);

internal readonly struct TestAccessor
{
private readonly DiagnosticService _diagnosticService;

internal TestAccessor(DiagnosticService diagnosticService)
=> _diagnosticService = diagnosticService;

internal ref readonly EventListenerTracker<IDiagnosticService> EventListenerTracker
=> ref _diagnosticService._eventListenerTracker;
}
}
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading