Update LSIF generator to latest bin log reader #67085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
|
Tagging @jasonmalinowski for a review. Do we expect the binlog version to change frequently? Is there a way that we can make this process a bit more automated and/or coordinated with the MSBuild team to minimize the period of time that a new toolset is unsupported? |
gundermanc
force-pushed
the
dev/chgund/UpdateStructuredBinLog
branch
2 times, most recently
from
97d699c to
5095f5f
Compare
jasonmalinowski
approved these changes
Feb 28, 2023
sharwell
reviewed
Feb 28, 2023
| @@ -11,6 +11,7 @@ | |||
| <ItemGroup> | |||
| <Reference Include="System" /> | |||
| <Reference Include="System.Core" /> | |||
| <Reference Include="System.IO.Compression" /> | |||
There was a problem hiding this comment.
Yes, it seems that ZipArchive was moved from one DLL to another and this generates a new compiler warning without the reference.
There was a problem hiding this comment.
This might indicate a packaging issue with whatever had the demand -- that could have been listed in the NuGet package itself. Not a big deal though.
gundermanc
force-pushed
the
dev/chgund/UpdateStructuredBinLog
branch
from
5095f5f to
3d7fca6
Compare
gundermanc
requested review from
sharwell and
jasonmalinowski
and removed request for
sharwell
jasonmalinowski
approved these changes
Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn LSIF generator chokes on 'version 16' bin logs. This PR updates to v16 so that it can properly generate LSIF for codebases/build-environments using newer SDKs.
Fixes AB#1743537