Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 17.5 CI build #67381

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Fix 17.5 CI build #67381

merged 4 commits into from
Mar 21, 2023

Conversation

genlu
Copy link
Member

@genlu genlu commented Mar 20, 2023

Port the change from 17.6 #66559

val build

@genlu genlu requested a review from a team as a code owner March 20, 2023 20:16
@genlu genlu marked this pull request as draft March 20, 2023 20:20
@genlu genlu marked this pull request as ready for review March 20, 2023 20:37
@genlu
Copy link
Member Author

genlu commented Mar 20, 2023

Val build got past the error we previously saw. This is ready for review,

@genlu
Copy link
Member Author

genlu commented Mar 20, 2023

Also needed to port this infra only change to 17.5 branch, to fix this validation error
#67085

@genlu genlu enabled auto-merge March 20, 2023 21:03
@genlu
Copy link
Member Author

genlu commented Mar 21, 2023

Integration test failure is known flaky issue
#67245
#67244

@genlu genlu merged commit d17f741 into dotnet:release/dev17.5-vs-deps Mar 21, 2023
@genlu genlu deleted the Fix17.5Ci branch March 21, 2023 17:57
dibarbet pushed a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants