From 26957453b565037aac2746c430a33e74d482dbb9 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Mon, 12 Jun 2023 10:22:22 -0700 Subject: [PATCH 1/2] remove stale comments --- .../CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs b/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs index e899c4da8b17f..b3b53ac98048b 100644 --- a/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs +++ b/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs @@ -3732,7 +3732,6 @@ public unsafe static void Main() } "); - // Support for `using unsafe static` tracked by https://github.com/dotnet/roslyn/issues/67329 verifyDiagnostics(comp0Ref, comp1Ref, @" using static C1*[]>; @@ -3757,7 +3756,6 @@ public static void Main() // _ = E1.F1 + 1; Diagnostic(ErrorCode.ERR_UnsafeNeeded, "E1.F1 + 1").WithLocation(7, 13)); - // Support for `using unsafe static` tracked by https://github.com/dotnet/roslyn/issues/67329 verifyDiagnostics(comp0Ref, comp1Ref, @" using static C1*[]>.E1; From 30217e4fa15af4249b31c572dbd3b3d6318c1fd6 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Tue, 13 Jun 2023 11:14:33 -0700 Subject: [PATCH 2/2] Add tests --- .../Symbol/Compilation/UsedAssembliesTests.cs | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs b/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs index b3b53ac98048b..dff6ce2c6815a 100644 --- a/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs +++ b/src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs @@ -3758,6 +3758,18 @@ public static void Main() verifyDiagnostics(comp0Ref, comp1Ref, @" +using static unsafe C1*[]>; +public class C2 +{ + public static unsafe void Main() + { + _ = E1.F1 + 1; + } +} +"); + + verifyDiagnostics(comp0Ref, comp1Ref, +@" using static C1*[]>.E1; public class C2 { @@ -3780,6 +3792,18 @@ public static void Main() // _ = F1 + 1; Diagnostic(ErrorCode.ERR_UnsafeNeeded, "F1 + 1").WithLocation(7, 13)); + verifyDiagnostics(comp0Ref, comp1Ref, +@" +using static unsafe C1*[]>.E1; +public class C2 +{ + public static unsafe void Main() + { + _ = F1 + 1; + } +} +"); + verify(comp0Ref, comp1Ref, @" using unsafe @alias = C1*[]>.E1;