Collection literals: address comments #68793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
cston
commented
Jun 27, 2023
| @@ -548,18 +548,13 @@ BoundExpression convertArrayElement(BoundExpression element, TypeSymbol elementT | |||
| } | |||
|
|
|||
| var implicitReceiver = new BoundObjectOrCollectionValuePlaceholder(syntax, isNewInstance: true, targetType) { WasCompilerGenerated = true }; | |||
| // PROTOTYPE: When generating a List<T>, should we use the well-known | |||
There was a problem hiding this comment.
Added open issue to test plan #66418.
cston
commented
Jun 27, 2023
| var collectionInitializerAddMethodBinder = this.WithAdditionalFlags(BinderFlags.CollectionInitializerAddMethod); | ||
| var builder = ArrayBuilder<BoundExpression>.GetInstance(node.Elements.Length); | ||
| foreach (var element in node.Elements) | ||
| { | ||
| var result = element switch | ||
| { | ||
| BoundBadExpression => element, | ||
| // PROTOTYPE: Should spread elements support target type? |
There was a problem hiding this comment.
Added open issue to test plan #66418.
cston
commented
Jun 27, 2023
| @@ -1173,7 +1173,6 @@ static void Main() | |||
| } | |||
| } | |||
| """; | |||
| // PROTOTYPE: Should compile and run successfully: expectedOutput: "[1, 2, 3], " | |||
cston
commented
Jun 27, 2023
| @@ -1325,7 +1324,6 @@ static void Main() | |||
| CompileAndVerify(new[] { source, s_collectionExtensions }, expectedOutput: "(System.Int32[]) [1, 2, 3], "); | |||
| } | |||
|
|
|||
| // PROTOTYPE: Test other variance cases. | |||
cston
commented
Jun 27, 2023
| @@ -2087,10 +2207,6 @@ static void Main() | |||
| } | |||
| } | |||
| """; | |||
| // PROTOTYPE: Confirm we should generate ListBase<int> instances for both x and y. | |||
cston
commented
Jun 27, 2023
| @@ -4156,7 +4272,7 @@ static void Main() | |||
| [ConditionalTheory(typeof(CoreClrOnly))] | |||
| [CombinatorialData] | |||
| public void SpreadElement_01( | |||
| [CombinatorialValues("IEnumerable", "IEnumerable<int>", "int[]", "List<int>", "Span<int>", "ReadOnlySpan<int>")] string spreadType, | |||
cston
commented
Jun 27, 2023
| @@ -4584,7 +4697,6 @@ static void Main() | |||
| } | |||
| """; | |||
| var comp = CreateCompilation(source); | |||
| // PROTOTYPE: Should spread elements support target type? (Should we infer IEnumerable<int>?) | |||
There was a problem hiding this comment.
Added open issue to test plan #66418.
cston
commented
Jun 27, 2023
| @@ -4606,7 +4718,6 @@ static string[] Append(string a, string b, bool c) | |||
| } | |||
| } | |||
| """; | |||
| // PROTOTYPE: Should spread elements support target type? (Should we infer IEnumerable<string>?) | |||
There was a problem hiding this comment.
Added open issue to test plan #66418.
cston
commented
Jun 27, 2023
| @@ -6303,33 +6441,5 @@ static async Task<T> F<T>(T t) | |||
| """; | |||
| CompileAndVerify(new[] { source, s_collectionExtensions }, expectedOutput: "[3, 1, 2, 4], "); | |||
| } | |||
|
|
|||
| [ConditionalFact(typeof(CoreClrOnly), AlwaysSkip = "PROTOTYPE: 'IAsyncEnumerable<int>' does not contain a definition for 'GetAwaiter'")] | |||
| public void Async_03() | |||
There was a problem hiding this comment.
Added open issue to test plan #66418: support IAsyncEnumerable<T> for spread element?
…nto collections-comments
333fred
reviewed
Jun 28, 2023
| @@ -5365,8 +5364,8 @@ public void CastVersusIndexAmbiguity24_B() | |||
| [Fact] | |||
| public void CastVersusIndexAmbiguity24_C() | |||
| { | |||
| // PROTOTYPE: This is not a great diagnostic. Users could easily run into this and be confused. Can we do | |||
| // better. For example: | |||
| // This is not a great diagnostic. Users could easily run into this and be confused. Can we do | |||
There was a problem hiding this comment.
This particular case involves a dictionary element which is not currently supported. I've logged an issue to improve the diagnostic for the previous example (A)[1]: #68862.
RikkiGibson
reviewed
Jun 28, 2023
| @@ -3836,7 +3836,6 @@ internal uint GetValEscape(BoundExpression expr, uint scopeOfTheContainingExpres | |||
| return GetValEscape(switchExpr.SwitchArms.SelectAsArray(a => a.Value), scopeOfTheContainingExpression); | |||
|
|
|||
| case BoundKind.CollectionLiteralExpression: | |||
| // PROTOTYPE: Revisit if spans may be optimized to avoid heap allocation. | |||
There was a problem hiding this comment.
We have a test plan #66418 item tracking this now.
RikkiGibson
approved these changes
Jun 28, 2023
…nto collections-comments
…nto collections-comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address PROTOTYPE comments.