Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to features/CollectionLiterals #68812

Merged
merged 744 commits into from
Jun 28, 2023
Merged

Merge main to features/CollectionLiterals #68812

merged 744 commits into from
Jun 28, 2023

Conversation

cston
Copy link
Member

@cston cston commented Jun 28, 2023

No description provided.

CyrusNajmabadi and others added 30 commits June 7, 2023 18:30
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into noThrowDelay
316b1f4
@CyrusNajmabadi
Add dummy callback
1b1c8b7
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into usePrimaryConstruct…
09989fc 
…orKeywordName
@CyrusNajmabadi
docs
08e783f
@CyrusNajmabadi
Revert
a4d55c4
@CyrusNajmabadi
Merge pull request dotnet#68390 from CyrusNajmabadi/usePrimaryConstru…
63d4074 
…ctorKeywordName

Fix 'use primary constructor' with nested types.
@AlekseyTs
Implement definite assignment and region analysis for inline array ty…
2c31d1c 
…pes (dotnet#68339)
@sharwell
Merge pull request dotnet#68457 from sharwell/fix-service
ce5a320 
Fix 'Use Local Function' fixer in code style layer
@sharwell
Merge pull request dotnet#68338 from sharwell/delays
6079208 
Use DelayTimeSpan where applicable
@AlekseyTs
Support 'foreach' for inline arrays. (dotnet#68297)
cf124b4 
https://github.com/dotnet/csharplang/blob/main/proposals/inline-arrays.md#the-foreach-statement
@sharwell
Update to Nerdbank.Streams 2.9.116
352d10c 
Fixes random test failures involving cancellation of ServiceHub requests.
@sharwell
Merge pull request dotnet#68492 from sharwell/update-streams
8412ca0 
Update to Nerdbank.Streams 2.9.116
@AlekseyTs
Merge 'main' into InlineArrays
bd4cedd
@CyrusNajmabadi
Update version of roslyn-analyzers that Roslyn itself uses
2cd15d6
@CyrusNajmabadi
Make shared
0642d36
@CyrusNajmabadi
Make static
1c80338
@AlekseyTs
Merge 'main' into InlineArrays (dotnet#68496)
c23d2c1
@CyrusNajmabadi
Make static
c9c8838
@CyrusNajmabadi
Make static
2af6113
@CyrusNajmabadi
Make static
fb2330f
@dibarbet
Merge pull request dotnet#68461 from dibarbet/dev/dibarbet/merge_lsp_…
384f18b 
…tools_host

Merge internal fork of LSP tools back into Roslyn
@CyrusNajmabadi
Make static
ffae0a9
@CyrusNajmabadi
Make static
cb236ff
@CyrusNajmabadi
Make static
49be7a3
@CyrusNajmabadi
Make static
c4d0c35
@CyrusNajmabadi
Merge branch 'main' into structureTag3
aca8aa4
@CyrusNajmabadi
Update versions
65cb2bd
@CyrusNajmabadi
Allocate less in GetTypeByMetadataName (dotnet#68415)
4b3255c 
* Initial stubs for less allocs

* Add type support

* Update helpers

* remove

* Break out type

* Fix

* Fix

* Fix

* Fix vb

* Update tests

* ToString

* ReverT

* move more cases over to memory

* move more cases over to memory

* Revert

* Revert

* renames

* Simplify assert

* Fix

* Rename

* Do the work for types as well

* Move methods down

* Ordering

* Simpler pattern

* revert

* Add docs

* Remove another alloc

* Shortcircuit common case

* Break helper into specific versions for compiler vs ide layers

* Use group-by

* remove

* Use explicit type

* make field

* Throw unreachable

* use explicit type

* use explicit type

* Don't allow

* newline

* use 'default'

* Be more explicit

* REmove assert

* Simplify

* Simplify

* Add assert

* Move assert

* Move local

* Add helper

* use constnat

* use constnat

* Simplify

* Fix

* Simplify

* Update src/Compilers/CSharp/Portable/Symbols/NamespaceOrTypeSymbol.cs

* Add assert

* Add assert back in

* use helper

* Use new arity scanning logic

* Simplify matching

* Update src/Features/LanguageServer/Protocol/Handler/SpellCheck/AbstractSpellCheckingHandler.cs
@CyrusNajmabadi
make static
06bce45
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into analyzersVersion
130cee7
AlekseyTs and others added 17 commits June 26, 2023 08:31
@AlekseyTs
Pack feature Id and error numbers
a254496
@tmat
EnC: Stop reporting CS7101 on runtime that supports generic updates (d…
419ee23 
…otnet#68601)
@AlekseyTs
Merge 'InlineArrays' feature into 'main' (dotnet#68783)
c22af05
@chsienki
Add razor compiler EA project ref (dotnet#68732)
b50a84b
@tmat
EnC: Implement support for editing types with primary constructors (d…
6af144c 
…otnet#68477)
@jcouv
Test GetTypeInfo on values given to missing attribute (dotnet#68427)
ce867ff
@Miizukii @jjonescz @CyrusNajmabadi
Fixed CA1854: Prefer IDictionary.TryGetValue(TKey, out TValue) occurr…
ab87b4f 
…ences (dotnet#66515)

* fixed CA1854 occurrences c#

* fixed CA1854 occurrences VB

* VB init with Nothing + fix formatting

* Address PR feedback

* Update src/Workspaces/Core/Portable/Rename/ConflictEngine/RenamedSpansTracker.cs

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

* remove redundant ifs

* Apply suggestions from code review

Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>

---------

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
@GrahamTheCoder
Fixes SyntaxFactory.UsingDirective overload which always throws (dotn…
87286e9 
…et#68762)

Fixes dotnet#68761
@tmat
More workarounds for VS Code project system issues (dotnet#68792)
bdbf1cb
@mavasani
Roslyn side changes to enable full solution background analysis in LS…
0f3200c 
…P/VSCode

Work towards dotnet#68553.
This needs a corresponding change in dotnet/vscode-csharp repo. I verified that this change + the corresponding vscode-csharp change enables FSA support in C# DevKit extension in VSCode.

Needs couple more Roslyn side fixes as a follow-up: dotnet#68797 and dotnet#68798
@mavasani
Merge pull request dotnet#68799 from mavasani/FSA_LSP
5d944ea 
Roslyn side changes to enable full solution background analysis in LSP/VSCode
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
faa8b81 
…626.5 (dotnet#68802)

[main] Update dependencies from dotnet/arcade
- Coherency Updates:
  - Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23312.2 to 1.0.0-beta.23319.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@ToddGrun
Update VSTelemetry package version
03e0624 
Should address our side of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1837883
@arunchndr
Merge pull request dotnet#68806 from ToddGrun/dev/toddgrun/UpdateVSTe…
01dc829 
…lemetryPackageVersion

Update VSTelemetry package version
@danmoseley
remove long gone owners (dotnet#68755)
5779db1
@davidwengier
Merge pull request dotnet#68744 from davidwengier/TokenModifiers
575bc42 
"Fix" LSP semantic token modifiers
@cston
Merge remote-tracking branch 'upstream/main' into collections-merge
f4f5b39
@cston cston requested review from a team as code owners June 28, 2023 12:12
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 28, 2023
@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jun 28, 2023 •
edited
Loading

@jaredpar Bootstrap failure shows a double write to D:\a\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.ExternalAccess.FSharp.UnitTests\Release\net472\Microsoft.VisualStudio.Text.Internal.dll. Reported in Build.binlog. Haven't we seen a failure like this before?

@RikkiGibson
Copy link
Contributor

Double write issue is suppressed in practice and tracked by #62372

@cston cston merged commit 308b868 into dotnet:features/CollectionLiterals Jun 28, 2023
@cston cston deleted the collections-merge branch June 28, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.