Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection expressions: synthesized list types should implement ICollection and IList #70288

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Collection expressions: synthesized list types should implement ICollection and IList #70288

merged 2 commits into from
Oct 17, 2023

Conversation

cston
Copy link
Member

@cston cston commented Oct 7, 2023 •
edited by jcouv
Loading

Fixes #70253

Relates to test plan #66418

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 7, 2023
@cston cston marked this pull request as ready for review October 7, 2023 21:52
@cston cston requested a review from a team as a code owner October 7, 2023 21:52
@cston cston requested review from 333fred, RikkiGibson and a team October 9, 2023 15:09
@cston cston changed the base branch from features/CollectionLiterals to main October 11, 2023 23:50
@cston
Copy link
Member Author

cston commented Oct 16, 2023

@dotnet/roslyn-compiler, please review, thanks.

@cston cston merged commit 8074cb4 into dotnet:main Oct 17, 2023
25 checks passed
@cston cston deleted the 70253 branch October 17, 2023 17:21
@ghost ghost added this to the Next milestone Oct 17, 2023
@allisonchou allisonchou mentioned this pull request Oct 18, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson Awaiting requested review from RikkiGibson

Assignees
No one assigned
Labels
Area-Compilers New Feature - Collection Expressions untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.

Collection expressions targeting readonly interfaces should provide an instance implementing nongeneric IList
3 participants
@cston @333fred @jjonescz