Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params Collections: misc chanages #71423

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Params Collections: misc chanages #71423

merged 3 commits into from
Jan 9, 2024

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Dec 30, 2023 •
edited
Loading

  • Params Collections in attributes
  • Params Collections in lambdas
  • Params Collections and interpolated string handler
  • Order of evaluation:
    • named arguments
    • compound assignment
    • object initializer

Also fixes #71488.

@AlekseyTs
Params Collections: misc chanages
11eca87 
- Params Collections in attributes
- Params Collections in lambdas
- Params Collections and interpolated string handler
- Order of evaluation:
    - named arguments
    - compound assignment
    - object initializer
@AlekseyTs AlekseyTs requested a review from a team as a code owner December 30, 2023 00:37
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 30, 2023
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review

333fred
333fred approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be good to add that test as well to see if this changed fixed the bug.

@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @dotnet/roslyn-compiler For the second review

@AlekseyTs AlekseyTs merged commit a9ffbe0 into dotnet:features/ParamsCollections Jan 9, 2024
25 checks passed
@dotnet-bot dotnet-bot mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - ParamsCollections untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @333fred @RikkiGibson