Razor internals #71762
Razor internals #71762
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -357,6 +357,11 @@ internal ValueTask<ImmutableArray<Diagnostic>> GetSourceGeneratorDiagnosticsAsyn | |||
| return _solution.CompilationState.GetSourceGeneratorDiagnosticsAsync(this.State, cancellationToken); | |||
| } | |||
|
|
|||
| internal ValueTask<GeneratorDriverRunResult?> GetSourceGeneratorRunResultAsync(CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
@jasonmalinowski In a previous version of this PR, we discussed if we should replace GetSourceGeneratorDiagnosticsAsync with this method.
I chose to keep them separate because the diagnostics path actually returns data in the GeneratedFileReplacingCompilationTracker path, where the run result just throws. If we can figure out what the semantics of get run result would be in the GeneratedFileReplacingCompilationTracker then we could collapse them into a single method.
|
@jasonmalinowski @CyrusNajmabadi for thoughts. |
|
|
||
| namespace Microsoft.CodeAnalysis.ExternalAccess.Razor | ||
| { | ||
| internal static class RazorProjectExtensions |
There was a problem hiding this comment.
Don't we keep track of the internal APIs for those EA assemblies as well? If so, I don't see the corresponding change in InternalAPI.Unshipped.txt
There was a problem hiding this comment.
Good catch, addded.
|
@chsienki I don't have the context on why this is needed, but the change itself looks good to me. |
chsienki
force-pushed
the
razor_internals2
branch
from
709c791 to
ed66ea8
Compare
chsienki
force-pushed
the
razor_internals2
branch
from
d367299 to
b86e404
Compare
Expose an extension via Razor EA that gives access to the
GeneratorDriverRunResultfor a given project.