Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler vsix deployment #72321

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix compiler vsix deployment #72321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@
<PackageVersion Include="System.IO.Pipelines" Version="$(SystemIOPipelinesVersion)" />
<PackageVersion Include="System.IO.Pipes.AccessControl" Version="5.0.0" />
<PackageVersion Include="System.Memory" Version="4.5.5" />
<PackageVersion Include="System.Numerics.Vectors" Version="4.5.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work in VS insertions? Won't it cause builds to fail for some reason? Should we do a validation run?

Copy link
Member Author

@dibarbet dibarbet Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjonescz this vsix isn't actually used for insertion - it uses one of Microsoft.CodeAnalysis.Compilers.x64/.arm64/.x64.vsix as the actual insertion VSIX

However weirder things have broken the VS build so I can run a val insertion to make sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks for explanation; I think it's fine then, we can always revert :)

<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
<PackageVersion Include="System.Runtime.Loader" Version="4.3.0" />
<PackageVersion Include="System.Resources.Extensions" Version="7.0.0" />
Expand Down
1 change: 1 addition & 0 deletions src/Compilers/Extension/Roslyn.Compilers.Extension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<PackageReference Include="System.Collections.Immutable" IncludeInVsix="true" />
<PackageReference Include="System.Memory" IncludeInVsix="true" />
<PackageReference Include="System.Reflection.Metadata" IncludeInVsix="true" />
<PackageReference Include="System.Numerics.Vectors" IncludeInVsix="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering whether BuildBoss shouldn't catch cases like this. cc @jaredpar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my concern as well. Generally BuildBoss should be used to catch inconsistencies like this. That is why I'm curious about what scenarios are not working today.

<PackageReference Include="System.Text.Encoding.CodePages" IncludeInVsix="true" />
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" IncludeInVsix="true" />
<PackageReference Include="System.Threading.Tasks.Extensions" IncludeInVsix="true" />
Expand Down
Loading