Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS SDK to 17.10.234-preview.1 #72359

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Update VS SDK to 17.10.234-preview.1 #72359

merged 1 commit into from
Mar 13, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Mar 1, 2024

Fixes #71377

@tmat tmat requested a review from a team as a code owner March 1, 2024 18:07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 1, 2024
@tmat tmat marked this pull request as draft March 1, 2024 18:07
@tmat tmat force-pushed the VS17.10 branch 2 times, most recently from 1cb3a9a to dfd1700 Compare March 1, 2024 20:28
@mthalman
Copy link
Member

Regarding the source build prebuilt:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24113.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Resources.Extensions.8.0.0

You configured everything correctly so that the System.Resources.Extensions package version will be overridden in the VMR build. However, outside of the VMR, repo builds do not have this behavior of overriding the package version for source build. So you'll need to add this package to the prebuilt baseline at https://github.com/dotnet/roslyn/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

@mthalman
Copy link
Member

Regarding the source build prebuilt:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24113.2/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Resources.Extensions.8.0.0

You configured everything correctly so that the System.Resources.Extensions package version will be overridden in the VMR build. However, outside of the VMR, repo builds do not have this behavior of overriding the package version for source build. So you'll need to add this package to the prebuilt baseline at https://github.com/dotnet/roslyn/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

This same change is being made in #72429: 0153f34

@tmat tmat marked this pull request as ready for review March 13, 2024 16:56
@tmat tmat changed the title Update VS SDK to 17.10.22-preview-1 Update VS SDK to 17.10.234-preview.1 Mar 13, 2024
@tmat tmat merged commit a093664 into dotnet:main Mar 13, 2024
30 checks passed
@tmat tmat deleted the VS17.10 branch March 13, 2024 21:15
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 13, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSTHRD004 is misreported in 17.9.3-alpha
4 participants