Small allocation optimization in StateTable.Builder.ToImmutable #72364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch buffer in StateTable.Builder.ToImmutable
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
Debated not making this change, but it was simple and safe enough that I figured it was worth it |
sharwell
reviewed
Mar 4, 2024
src/Compilers/Core/Portable/SourceGeneration/Nodes/StateTableStore.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/SourceGeneration/Nodes/StateTableStore.cs
Outdated
Show resolved
Hide resolved
Free scratch array back to pool
|
@dotnet/roslyn-compiler -- ptal |
|
waiting on #72395 as it will provide a cleaner way to do this |
Modified this PR to now use SegmentedCollectionsMarshal.GetValueRefOrNullRef instead of a scratch array. |
sharwell
approved these changes
Mar 19, 2024
333fred
approved these changes
Mar 19, 2024
jjonescz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an ArrayBuilder as a scratch buffer instead of allocating an array every time. Small allocation that barely showed up in the RichCopyTest speedometer test.
*** Previous allocations
