Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small allocation optimization in StateTable.Builder.ToImmutable #72364

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Small allocation optimization in StateTable.Builder.ToImmutable #72364

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73904d2
Small performance optimization around using an ArrayBuilder as a scra…
ToddGrun Mar 2, 2024
ae787c6
Only replace non-cached items
ToddGrun Mar 4, 2024
72b3362
Merge branch 'dotnet:main' into dev/toddgrun/StateTableBuilderToImmut…
ToddGrun Mar 19, 2024
ef302bb
Use SegmentedCollectionsMarshal.GetValueRefOrNullRef instead of scrat…
ToddGrun Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/Compilers/Core/Portable/SourceGeneration/Nodes/StateTableStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Text;
using Microsoft.CodeAnalysis.Collections;

namespace Microsoft.CodeAnalysis
Expand Down Expand Up @@ -51,10 +47,13 @@ public sealed class Builder
public StateTableStore ToImmutable()
{
// we can cache the tables at this point, as we'll no longer be using them to determine current state
var keys = _tableBuilder.Keys.ToArray();
ToddGrun marked this conversation as resolved.
Show resolved Hide resolved
foreach (var key in keys)
foreach (var kvp in _tableBuilder)
{
_tableBuilder[key] = _tableBuilder[key].AsCached();
var cachedValue = kvp.Value.AsCached();
if (cachedValue != kvp.Value)
{
SegmentedCollectionsMarshal.GetValueRefOrNullRef(_tableBuilder, kvp.Key) = cachedValue;
}
}

return new StateTableStore(_tableBuilder.ToImmutable());
Expand Down
Loading