Merge 'main' into ParamsCollections #72390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider.GetSymbolsAsync (dotnet#72157) This method was individually adding items to an ArrayBuilder without it's size configured. Potential issues with the current approach: 1) There could be multiple resizes during the Add calls to get the array to it's final size 2) Very likely the final capacity will exceed the array size, causing an allocation in generating the immutablearray. 3) I was seeing a large number of items in these arrays, causing the array that does get created not to get freed back into the pool. Instead, if we use the SelectAsArray method, we shouldn't have any extra allocations other than the resultant ImmutableArray.
* Fix rethrowing in nested async catch * Test await using and foreach
Razor is doing work to consolidate assemblies, and it's necessary to add a couple more IVTs from the Razor EA assembly. In addition, I'm removing an IVT for an assembly that no longer exists.
…ice` in `OnInitializedAsync()`. - Add EA.Xaml reference to MS.CA.LanguageServer
…olsInternal (dotnet#72153) During completion, I see this method generating results with several thousand entries which is evident in allocations in a profile I'm inspecting. This change reduces intermediary arrays constructed during that process by modifying FilterNotReferenceable and FilterOverriddenOrHiddenIndexers to not require realization of an ImmutableArray as input.
…72350) This was expressing itself as instability in unit tests. The underlying issue (that Sam found!) was that the CreateCompilationTrackerMap was recently modified such that it dereferenced _projectIdToTrackerMap several times. Unfortunately, this value can be changed during this method's execution, so there was no guarantee that all dereferences were using the same object. The primary fix here is to use a local that guarantees they all use the same object. Without this change, I would hit several failures in TestCommitAfterEnterOnBlankLine when running the test locally several thousand times. With this change, I no longer hit a failure when running the test locally 10K times. There are a couple other small changes that Sam suggested as part of this PR, primarily being a bit more precise in the callback's return value indicating whether the trackermap was modified.
This reverts commit c3b4361.
…o-main Merge release/dev17.10 to main
…t#72313) Ensure ProjectState modification operations would actually create a modified ProjectState before creating the new ProjectState When opening Roslyn.sln, I see 32800 ProjectState.AddDocument calls, of which 6700 are sending in an empty array to add. Similarly, I see 6700 ProjectState.RemoveAllDocuments calls, of which 4700 are called on ProjectState instances where the DocumentStates/AdditionalDocumentStates/AnalyzerConfigDocumentStates are all empty.
Boxing of the EntryState enum shows up in the RichCopyTest.CopyPlain test numbers as almost 1% of allocations. This code just needs to map EntryState values to a character for packing.
Lexer.LexDirectiveTrailingTrivia was calling into AddTrivia with a null SyntaxListBuilder, causing allocations. Instead, use a new member for use in that context.
UsingToolNetFrameworkReferenceAssemblies got removed from Arcade a while ago as the SDK supports that natively.
|
@dotnet/roslyn-compiler Need a sign-off on a merge PR. Trivial merges |
dotnet-issue-labeler
bot
added
the
untriaged
|
Looks like correctness fails with: |
jjonescz
approved these changes
Mar 5, 2024
AlekseyTs
merged commit 811c275
into
dotnet:features/ParamsCollections
25 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.