Remove code for arbitrary diagnostic taggers #72409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 7, 2024
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| #nullable disable |
There was a problem hiding this comment.
no longer used. missed in prior PRs.
CyrusNajmabadi
commented
Mar 7, 2024
| @@ -91,9 +91,6 @@ protected sealed override ITaggerEventSource CreateEventSource(ITextView? textVi | |||
| private async Task ProduceTagsAsync( | |||
| TaggerContext<TTag> context, DocumentSnapshotSpan documentSpanToTag, CancellationToken cancellationToken) | |||
| { | |||
| if (!_callback.IsEnabled) | |||
There was a problem hiding this comment.
no concept of 'enabled' or not. inline diagnostics aren't enabled/disabled depending on if we're using lsp diagnostics or not.
CyrusNajmabadi
commented
Mar 7, 2024
| @@ -111,4 +111,36 @@ private static ITaggerEventSource CreateEventSourceWorker(ITextBuffer subjectBuf | |||
| TaggerEventSources.OnDiagnosticsChanged(subjectBuffer, diagnosticService), | |||
| TaggerEventSources.OnTextChanged(subjectBuffer)); | |||
| } | |||
|
|
|||
| protected ITagSpan<TTag>? CreateTagSpan(Workspace workspace, SnapshotSpan span, DiagnosticData data) | |||
There was a problem hiding this comment.
moved from intermediary subclass to this type. methods unchanged.
CyrusNajmabadi
commented
Mar 7, 2024
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.InlineDiagnostics | ||
| namespace Microsoft.CodeAnalysis.Editor.InlineDiagnostics; |
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Mar 7, 2024
| IEditorFormatMapService editorFormatMapService, | ||
| IClassificationFormatMapService classificationFormatMapService, | ||
| IClassificationTypeRegistryService classificationTypeRegistryService) | ||
| : AbstractDiagnosticsTaggerProvider<InlineDiagnosticsTag>( |
There was a problem hiding this comment.
moved to primary constructor. and now derives from AbstractDiagnosticsTaggerProvider. AbstractDiagnosticsAdornmentTaggerProvider was merged into AbstractDiagnosticsTaggerProvider
akhera99
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only have the inline-diagnostics tagger now. So moved all code related to that to a single location.
Followup to #62735.