Fix log contention issue #72419
Merged
Fix log contention issue #72419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes another log contention issue we were seeing in CI. This was not caught in dotnet#72263 because the syntax generation only ran conditionally hence masked this problem.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jaredpar
commented
Mar 6, 2024
| @@ -409,7 +409,6 @@ stages: | |||
| - pwsh: | | |||
| ./eng/generate-compiler-code.ps1 -test -configuration Release | |||
| displayName: Generate Syntax Files | |||
| condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true')) | |||
There was a problem hiding this comment.
This step takes ~30 seconds to complete and is not part of the longest job for CI. Hence conditionalizing this complicates our CI without making throughput any faster. Removing the conditional to simplify this path.
|
@dotnet/roslyn-infrastructure PTAL |
333fred
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another log contention issue we were seeing in CI. This was not caught in #72263 because the syntax generation only ran conditionally hence masked this problem.