Standardize our Powershell code #72423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
@dotnet/roslyn-infrastructure PTAL |
jjonescz
approved these changes
Mar 8, 2024
| # DO | ||
| Exec-Command $command $args | ||
| & eng/make-bootstrap.ps1 | ||
| Test-LastExitCode |
There was a problem hiding this comment.
What was wrong with Exec-Script?
There was a problem hiding this comment.
It is very difficult to pass switch based values between scripts with Exec-Script and Powershell. For example the following is tricky:
Exec-Script "eng/build.ps1" "-ci:$ci" That turns into -ci:true which isn't a valid Powershell calling syntax.
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
|
Not sure why AzDO got disconnected from the PR but here is the build with all passing tests https://dnceng-public.visualstudio.com/public/_build/results?buildId=593595&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #72341 I made an attempt to standardize our Powershell on pwsh. Unfortunately attempting to get that PR green revealed a number of issues and in following up on those issues with core-eng I came to the conclusion that it's not possible to move fully to pwsh at this time. The issue is that there are downstream consumers of our repo that use Powershell and they have no plans to move hence moving here will just end up breaking source build, unified build, etc ...
As a result I went through our code and removed all of the existing pwsh usage. I also took the time to update our Powershell Guidelines document to enforce using Powershell as well as a few other items. Then I went through our Powershell scripts and ensured they conformed to these guidelines.
The one place that remains able to usee pwsh is our VSCode supporting scripts as that is not part of our build infra.