Use AsyncBatchingWorkQueue instead of TaskQueue #72425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Successfully linked to Azure Boards work item(s): |
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
src/Features/LanguageServer/Protocol/Features/Diagnostics/DiagnosticService.cs
Show resolved
Hide resolved
| { | ||
| using var argsBuilder = TemporaryArray<DiagnosticsUpdatedArgs>.Empty; | ||
| // No work to do. Avoid adding an empty args collection to _eventQueue because that is used to represent | ||
| // an operation from RaiseDiagnosticsCleared. |
There was a problem hiding this comment.
is this the same logic we had preivously? trying to find it.
There was a problem hiding this comment.
ok. i think i've wrapped my head around this. but i def find it confusing. could we instead enqueue this information as a boolean into the ABWQ instead?
| // listener should have already created since all events are done in the serialized queue | ||
| ev.RaiseEvent(static (handler, arg) => handler(arg.source, arg.args), (source, args: argsBuilder.ToImmutableAndClear())); | ||
| }, CancellationToken.None); | ||
| private void RaiseDiagnosticsCleared(IDiagnosticUpdateSource source) |
There was a problem hiding this comment.
i'm not really understanding who is calling this.
There was a problem hiding this comment.
➡️ The caller is abstracted a few layers. There is an event hookup here:
src/Features/LanguageServer/Protocol/Features/Diagnostics/DiagnosticService.cs
Outdated
Show resolved
Hide resolved
3 tasks
|
@CyrusNajmabadi thoughts on a for/against here? |
sharwell
force-pushed
the
diagnostics-queue
branch
from
cc798a4 to
a66eace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made during a review of AB#1949588. During the review, I failed to recognize a red herring in the automated analysis pipeline, which suggested that a high-hitting bug in 17.8 was still present in 17.9 and newer. In reality, the issue was already fixed for 17.9 Preview 1 by #70039, and internal analysis data confirms that there are no remaining known cases where
DiagnosticService._eventQueueis consuming significant amounts of memory.