Ensure obsolete diagnostics about required constructor or Add method is suppressible. #72426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
RikkiGibson
reviewed
Mar 6, 2024
| { | ||
| static void Main() | ||
| { | ||
| #line 100 |
There was a problem hiding this comment.
Is use of #line relevant to the test?
There was a problem hiding this comment.
Is use of
#linerelevant to the test?
I used it intentionally, it is reflected in the line numbers for diagnostics in the base line
RikkiGibson
approved these changes
Mar 6, 2024
333fred
reviewed
Mar 6, 2024
|
|
||
| class MyCollection : IEnumerable<long> | ||
| { | ||
| [System.Obsolete()] |
There was a problem hiding this comment.
Is it worth it to add variations for Experimental as well?
There was a problem hiding this comment.
Is it worth adding variations for
Experimentalas well?
I do not think so, they are supposed to be handled uniformly. The only difference is the attribute name.
There was a problem hiding this comment.
Context for suppression comes from the binder
333fred
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.