Remove unused diagnostic methods #72445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 7, 2024
| @@ -197,169 +195,6 @@ private void OnCleared(object? sender, EventArgs e) | |||
| RaiseDiagnosticsCleared((IDiagnosticUpdateSource)sender!); | |||
| } | |||
|
|
|||
| public ValueTask<ImmutableArray<DiagnosticData>> GetDiagnosticsAsync( | |||
There was a problem hiding this comment.
no actual product code called the two public methods below. removed them and all tehir supporting helpers.
CyrusNajmabadi
commented
Mar 7, 2024
| Await waiter.ExpeditedWaitAsync() | ||
|
|
||
| Dim diagnosticService = environment.ExportProvider.GetExportedValue(Of IDiagnosticService) | ||
| Dim diagnostics = Await diagnosticService.GetDiagnosticsAsync( |
There was a problem hiding this comment.
this test called through the service to then do work that it validated. so the service existed just to make this code pass. it was otherwise not observable. Removed entirely.
ToddGrun
reviewed
Mar 7, 2024
src/Features/LanguageServer/Protocol/Features/Diagnostics/DiagnosticService.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods had no callers except for in tests. Removed them, and the complexity around them.
Note: IDiagnosticService is ancient. For getting diagnostics it was superseded by several other better services. It exists now only as an eventing source to know when diagnostics change.