Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic snippets: Do not generate async write in cw snippet #72477

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Semantic snippets: Do not generate async write in cw snippet #72477

merged 1 commit into from
Mar 11, 2024

Conversation

DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 10, 2024 19:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 10, 2024
@DoctorKrolic

This comment was marked as resolved.

Sign in to view
@DoctorKrolic
Copy link
Contributor Author

I think this is ready to be merged

@sharwell sharwell merged commit fc58c2a into dotnet:main Mar 11, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 11, 2024
@DoctorKrolic DoctorKrolic deleted the no-async-console branch March 11, 2024 18:00
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@DoctorKrolic @sharwell @RikkiGibson