Provide option to only update source-generators on special events (like a build) #72494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 12, 2024
| @@ -40,4 +37,7 @@ public static WorkspaceConfigurationOptions GetWorkspaceConfigurationOptions(thi | |||
|
|
|||
| public static readonly Option2<bool> EnableOpeningSourceGeneratedFilesInWorkspaceFeatureFlag = new( | |||
| "dotnet_enable_opening_source_generated_files_in_workspace_feature_flag", WorkspaceConfigurationOptions.Default.EnableOpeningSourceGeneratedFiles); | |||
|
|
|||
| public static readonly Option2<bool> RunSourceGeneratorsExplicitly = new( | |||
| "dotnet_run_source_generators_explicitly", WorkspaceConfigurationOptions.Default.RunSourceGeneratorsExplicitly); | |||
There was a problem hiding this comment.
@tmat do i need to do anything to ensure that this works if the user sets this in their editorconfig?
This was referenced Mar 12, 2024
Closed
CyrusNajmabadi
commented
Mar 12, 2024
| @@ -61,9 +61,6 @@ | |||
| Content="{x:Static local:AdvancedOptionPageStrings.Option_run_code_analysis_on_dotnet}" /> | |||
| </StackPanel> | |||
|
|
|||
| <CheckBox x:Name="Analyze_source_generated_files" | |||
| Content="{x:Static local:AdvancedOptionPageStrings.Option_analyze_source_generated_files}" /> | |||
There was a problem hiding this comment.
moved down to a dedicated source-generator section.
CyrusNajmabadi
commented
Mar 12, 2024
|
|
||
| var bindingExpression = radiobutton.SetBinding(RadioButton.IsCheckedProperty, binding); | ||
| _bindingExpressions.Add(bindingExpression); | ||
| } |
There was a problem hiding this comment.
same as the code below. just works for options that are not PerLanguage ones.
There was a problem hiding this comment.
this code was needed to support a non-per-language nullable enum option value.
ToddGrun
reviewed
Apr 4, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 4, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_Checksum.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 4, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SourceGeneratorExecutionVersion.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 4, 2024
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 4, 2024
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #72490
This approach ensures that when SGs are very expensive (even incremental ones) that they can be set to run only when a build happens. That allows hte price to be paid at that point, with all further compilation requests using the results of that SG run up until the point of the next run.
This puts the user in control of that expense and provides a buffer against poorly run (or just very very expensive) generators. This is user configurable, allowing users to pick between this behavior, or the current behavior where generators just run automatically after any change.
Options looks like this:
There's also an option to force reloading of generators:
Tests incoming.