Disallow modifiers in local_using_declaration #72589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
333fred
reviewed
Mar 20, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/UsingDeclarationTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Mar 21, 2024
|
@dotnet/roslyn-compiler for a second review. Thanks |
cston
reviewed
Mar 21, 2024
| @@ -7902,4 +7902,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ | |||
| <data name="ERR_ParamsCollectionMissingConstructor" xml:space="preserve"> | |||
| <value>Non-array params collection type must have an applicable constructor that can be called with no arguments.</value> | |||
| </data> | |||
| <data name="ERR_NoModifiersOnUsing" xml:space="preserve"> | |||
| <value>Modifiers cannot be placed on resource declarations</value> | |||
cston
reviewed
Mar 21, 2024
| // (1,39): error CS1002: ; expected | ||
| // using (const var obj2 = new object()) { } | ||
| Diagnostic(ErrorCode.ERR_SemicolonExpected, "{").WithLocation(1, 39)); | ||
| } |
There was a problem hiding this comment.
const cases are tested in ModifiersInUsingLocalDeclarations_Const and ModifiersInUsingLocalDeclarations_Const_Async
Never mind, you meant with an explicit type... Sorry for the confusion
cston
reviewed
Mar 21, 2024
| // (1,44): error CS1002: ; expected | ||
| // await using (const var obj = new object()) { } | ||
| Diagnostic(ErrorCode.ERR_SemicolonExpected, "{").WithLocation(1, 44)); | ||
| } |
cston
reviewed
Mar 21, 2024
| { | ||
| void M() | ||
| { | ||
| using const System.IAsyncDisposable obj = null; |
There was a problem hiding this comment.
It looks like the cases in this test should be IDisposable rather than IAsyncDisposable.
cston
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72496