Remove unnecessary string[] allocations #72642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of the `GetAllItems` call was a fresh `string[]` that was being copied via collection initializer into a `List<T>`. That produces unnecessary allocations. This is particularly problematic because these allocations tend to end up in the LOH. Changed the API to be more explicit and consumer to not do the unnecessary allocations. This saved 73MB in LOH allocations.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
sharwell
approved these changes
Mar 21, 2024
cston
approved these changes
Mar 21, 2024
jjonescz
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of the
GetAllItemscall was a freshstring[]that was being copied via collection initializer into aList<T>. That produces unnecessary allocations. This is particularly problematic because these allocations tend to end up in the LOH.Changed the API to be more explicit and consumer to not do the unnecessary allocations. This saved 73MB in LOH allocations.