-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused resource strings #72648
Merged
CyrusNajmabadi
merged 18 commits into
dotnet:main
from
CyrusNajmabadi:removedUnusedResourceString
Mar 21, 2024
Merged
Remove unused resource strings #72648
CyrusNajmabadi
merged 18 commits into
dotnet:main
from
CyrusNajmabadi:removedUnusedResourceString
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Mar 21, 2024
CyrusNajmabadi
force-pushed
the
removedUnusedResourceString
branch
from
March 21, 2024 19:35
c1499e9
to
0e0d8dc
Compare
CyrusNajmabadi
force-pushed
the
removedUnusedResourceString
branch
from
March 21, 2024 19:36
0e0d8dc
to
2d8112d
Compare
CyrusNajmabadi
changed the title
Remove unused resource string
Remove unused resource strings
Mar 21, 2024
CyrusNajmabadi
commented
Mar 21, 2024
<data name="Remove_unnecessary_suppression_operator" xml:space="preserve"> | ||
<value>Remove unnecessary suppression operator</value> | ||
</data> | ||
<data name="Suppression_operator_has_no_effect_and_can_be_misinterpreted" xml:space="preserve"> | ||
<value>Suppression operator has no effect and can be misinterpreted</value> | ||
</data> | ||
<data name="typeof_can_be_converted_ to_nameof" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
busted resource string. fixed it up.
genlu
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually look at any of the strings you removed. Also maybe add this tool to the repo too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.