Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused resource strings #72648

Merged
merged 18 commits into from
Mar 21, 2024

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 21, 2024
@CyrusNajmabadi CyrusNajmabadi force-pushed the removedUnusedResourceString branch from c1499e9 to 0e0d8dc Compare March 21, 2024 19:35
@CyrusNajmabadi CyrusNajmabadi force-pushed the removedUnusedResourceString branch from 0e0d8dc to 2d8112d Compare March 21, 2024 19:36
@CyrusNajmabadi CyrusNajmabadi changed the title Remove unused resource string Remove unused resource strings Mar 21, 2024
<data name="Remove_unnecessary_suppression_operator" xml:space="preserve">
<value>Remove unnecessary suppression operator</value>
</data>
<data name="Suppression_operator_has_no_effect_and_can_be_misinterpreted" xml:space="preserve">
<value>Suppression operator has no effect and can be misinterpreted</value>
</data>
<data name="typeof_can_be_converted_ to_nameof" xml:space="preserve">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busted resource string. fixed it up.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review March 21, 2024 20:16
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually look at any of the strings you removed. Also maybe add this tool to the repo too

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners March 21, 2024 20:16
@CyrusNajmabadi CyrusNajmabadi merged commit 5bc6de4 into dotnet:main Mar 21, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 21, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the removedUnusedResourceString branch March 22, 2024 01:57
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants