Simplify updating the primary workspace without passing in a version #72688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 22, 2024
| @@ -60,9 +60,6 @@ internal sealed class SolutionChecksumUpdater | |||
| listener, | |||
| shutdownToken); | |||
|
|
|||
| // Use an equality comparer here as we will commonly get lots of change notifications that will all be | |||
| // associated with the same cancellation token controlling that batch of work. No need to enqueue the same | |||
| // token a huge number of times when we only need the single value of it when doing the work. | |||
There was a problem hiding this comment.
comment was stale. no equality comaprer was passed at all. this was before we had the arg-less ABWQ.
CyrusNajmabadi
commented
Mar 22, 2024
| @@ -142,17 +139,15 @@ private void OnWorkspaceChanged(object? sender, WorkspaceChangeEventArgs e) | |||
|
|
|||
| private async ValueTask SynchronizePrimaryWorkspaceAsync(CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
this is called, serially, by the ABWQ. So we never have to be concerned about the workspace version soemhow going downwards.
dibarbet
approved these changes
Mar 23, 2024
sharwell
reviewed
Mar 25, 2024
| @@ -90,13 +83,12 @@ public AssetProvider CreateAssetProvider(Checksum solutionChecksum, SolutionAsse | |||
| Func<Solution, ValueTask<T>> implementation, | |||
| CancellationToken cancellationToken) | |||
| { | |||
| return RunWithSolutionAsync(assetProvider, solutionChecksum, workspaceVersion: -1, updatePrimaryBranch: false, implementation, cancellationToken); | |||
There was a problem hiding this comment.
📝 This instance of workspaceVersion was never used because updatePrimaryBranch is set to false and accesses of the version are gated by it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the host already guarantees we only move the primary-solution forward in a monotonic fashion. And we only send the next event when teh prior completes. So all this complexity around workpsace versions during syncing is entirely unnecessary.