Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove visual_studio_workspace_partial_load_mode feature flag option #72689

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Remove visual_studio_workspace_partial_load_mode feature flag option #72689

merged 1 commit into from
Mar 23, 2024

Conversation

CyrusNajmabadi
Copy link
Member

We've been running in this state for effectively forever now. We have no need for this feature flag anymore.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 23, 2024 00:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 23, 2024
@CyrusNajmabadi CyrusNajmabadi requested a review from genlu March 23, 2024 00:31
@CyrusNajmabadi
Copy link
Member Author

@genlu ptal

@CyrusNajmabadi
Copy link
Member Author

@dibarbet ptal :)

@CyrusNajmabadi CyrusNajmabadi requested a review from dibarbet March 23, 2024 03:52
ToddGrun
ToddGrun approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 71ea819 into dotnet:main Mar 23, 2024
27 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the removeOptionFlag branch March 23, 2024 19:47
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 23, 2024
@sharwell sharwell changed the title Remove feature flag option Remove visual_studio_workspace_partial_load_mode feature flag option Mar 25, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@genlu genlu Awaiting requested review from genlu

@dibarbet dibarbet Awaiting requested review from dibarbet

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @RikkiGibson