Move large static array out of hte large object heap #73299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
commented
May 2, 2024
| @@ -63,7 +65,11 @@ private struct Entry | |||
| // slightly slower than local cache | |||
| // we read this cache when having a miss in local cache | |||
| // writes to local cache will update shared cache as well. | |||
| #if COMPILERCORE | |||
There was a problem hiding this comment.
note: i could make this change for the compiler as well, but i wasn't sure if tehre would be risk aversity around this core data structure.
AlekseyTs
reviewed
May 2, 2024
|
@dotnet/roslyn-compiler for reviews :) |
jaredpar
approved these changes
May 2, 2024
333fred
reviewed
May 2, 2024
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
333fred
approved these changes
May 2, 2024
arunchndr
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is showing up in speedometer runs for the IDE. making a trivial change to move this out of the LOH.