Have code action tests run in OOP mode by default #73372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 7, 2024
| internal partial class SerializerService | ||
| { | ||
| [DebuggerDisplay("{" + nameof(Display) + ",nq}")] | ||
| private sealed class SerializedMetadataReference : PortableExecutableReference, ISupportTemporaryStorage |
There was a problem hiding this comment.
just an extrac of a class. no changes to it at all.
|
@ToddGrun ptal |
CyrusNajmabadi
commented
May 7, 2024
| if (analyzer != null) | ||
| { | ||
| Contract.ThrowIfTrue(parameters.testHost == TestHost.OutOfProcess, $"Out-of-proc testing is not supported since {analyzer} can't be serialized."); |
There was a problem hiding this comment.
instead of asserting and not allowing this. We just make it so AnalyzerImageReference do work in OOP when in test scenarios.
CyrusNajmabadi
commented
May 7, 2024
| @@ -102,24 +103,21 @@ internal override Task<CodeRefactoring> GetCodeRefactoringAsync(TestWorkspace wo | |||
|
|
|||
| protected static void AddAnalyzerToWorkspace(Workspace workspace, DiagnosticAnalyzer analyzer, TestParameters parameters) | |||
There was a problem hiding this comment.
no clue why this method is duplicated. not interested in fixing that right now :)
CyrusNajmabadi
commented
May 8, 2024
| @@ -166,7 +166,7 @@ public InProcRemoteServices(SolutionServices workspaceServices, TraceListener? t | |||
| { | |||
| var remoteLogger = new TraceSource("InProcRemoteClient") | |||
| { | |||
| Switch = { Level = SourceLevels.Verbose }, | |||
| Switch = { Level = SourceLevels.Off }, | |||
There was a problem hiding this comment.
needed to change this because the amount of cost of this logging, over the stdout pipe which xunit captures, was actually slowing down tests too much! =-o
ToddGrun
reviewed
May 8, 2024
| var guid = reader.ReadGuid(); | ||
| lock (s_analyzerImageReferenceMapGate) | ||
| { | ||
| Contract.ThrowIfFalse(s_analyzerImageReferenceMap.TryGetKey(guid, out var analyzerImageReference)); |
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the mode users run in, and we want to verify that any work they do that involves communicating with OOP are tested by our standard unit tests.