Provide solution methods to allow updating a bulk set of documents at once. #73394
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -185,28 +185,35 @@ private static async Task<VersionStamp> ComputeLatestDocumentVersionAsync(TextDo | |||
| } | |||
|
|
|||
| private AsyncLazy<VersionStamp> CreateLazyLatestDocumentTopLevelChangeVersion( | |||
There was a problem hiding this comment.
view with whitespace off.
| : contentChanged | ||
| ? CreateLazyLatestDocumentTopLevelChangeVersion(newDocument, newDocumentStates, newAdditionalDocumentStates) | ||
| : _lazyLatestDocumentTopLevelChangeVersion; | ||
| if (recalculateDocumentVersion) |
There was a problem hiding this comment.
i broke the nested conditionals into if-statements as it was breaking my brain.
| @@ -162,7 +162,7 @@ private async Task<Checksum> ComputeDependentChecksumAsync(SolutionCompilationSt | |||
| { | |||
| // The generated file still exists in the underlying compilation, but the contents may not match the open file if the open file | |||
| // is stale. Replace the syntax tree so we have a tree that matches the text. | |||
| newStates = newStates.SetState(id, replacementState); | |||
| newStates = newStates.SetState(replacementState); | |||
There was a problem hiding this comment.
passing 'id' is redundant. it's already retrievable off of hte stat eobject passed in.
| return currentSolution; | ||
| return args.originalSolution | ||
| .WithDocumentSyntaxRoots(syntaxRoots.ToImmutableAndClear()) | ||
| .WithDocumentTexts(newTexts.ToImmutableAndClear()); |
There was a problem hiding this comment.
i audited the places i just added :) i will also look for other usages of WithDocumentSyntaxRoot and see if any cleanly can move over.
| // corresponds to the common case of a single file being edited. | ||
| return newStates.Length == 1 | ||
| ? new TouchDocumentAction(oldProjectState, newProjectState, oldProjectState.DocumentStates.GetRequiredState(newStates[0].Id), newStates[0]) | ||
| : new TouchDocumentsAction(oldProjectState, newProjectState, newStates); |
There was a problem hiding this comment.
i don't love this. but there is special logic in TouchDocumentAction (not plural). It's unclear to me how to maintain that logic here. So i'm solving it in this fashion.
| var oldState = this.OldProjectState.DocumentStates.GetRequiredState(newState.Id); | ||
| finalCompilation = finalCompilation.ReplaceSyntaxTree( | ||
| await oldState.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false), | ||
| await newState.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false)); |
There was a problem hiding this comment.
note: compiler lacks a bulk replace option. And i don't want to removeall+addall, as that would reorder trees.
|
|
||
| /// <inheritdoc cref="TouchDocumentAction.CanUpdateCompilationWithStaleGeneratedTreesIfGeneratorsGiveSameOutput"/> | ||
| public override bool CanUpdateCompilationWithStaleGeneratedTreesIfGeneratorsGiveSameOutput | ||
| => true; |
There was a problem hiding this comment.
note 100% sure about this @jasonmalinowski . however, as it is true for TouchDocumentAction, i don't know why it would not be true here just because we're touching multiple docs.
| private SolutionCompilationState UpdateDocumentsInMultipleProjects<TDocumentState>( | ||
| IEnumerable<(ProjectId projectId, ImmutableArray<TDocumentState> updatedDocumentState)> projectIdAndUpdatedDocuments, | ||
| Func<ProjectState, ImmutableArray<TDocumentState>, TranslationAction> updatedDocumentsToProjectState) | ||
| where TDocumentState : TextDocumentState |
There was a problem hiding this comment.
this is the exact same as the old method, just with teh name tweaked. if we can come up with a good name for both usages, we can remove one forwarding call from the method above.
| return UpdateDocumentsInMultipleProjects(projectIdAndNewDocuments, addDocumentsToProjectState); | ||
| } | ||
|
|
||
| private SolutionCompilationState UpdateDocumentsInMultipleProjects<TDocumentState>( |
There was a problem hiding this comment.
yes. removed hte old one.
|
@jasonmalinowski For review when you get back. |
Useful for fix-all scenarios where we don't want to fork the solution N times per document changed. This now allows there to just be a single fork we apply at once.