Produce less string allocs while formatting documents #73452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 13, 2024
| if (!previousToken.ContainsAnnotations && !currentToken.ContainsAnnotations) | ||
| return false; | ||
|
|
||
| if (!previousToken.HasTrailingTrivia && !currentToken.HasLeadingTrivia) |
There was a problem hiding this comment.
just formatting so i could understand the code.
CyrusNajmabadi
commented
May 13, 2024
| => t == null; | ||
|
|
||
| public static bool IsNotNull<T>(T t) where T : class | ||
| => !IsNull(t); |
CyrusNajmabadi
commented
May 13, 2024
|
|
||
| return previousToken.TrailingTrivia.HasAnyWhitespaceElasticTrivia() || currentToken.LeadingTrivia.HasAnyWhitespaceElasticTrivia(); | ||
| } | ||
|
|
||
| public static bool IsNull<T>(T t) where T : class | ||
| => t == null; |
There was a problem hiding this comment.
mostly pointless. so inlined.
CyrusNajmabadi
commented
May 13, 2024
| @@ -53,7 +54,8 @@ public static bool ContainsElasticTrivia(this SuppressOperation operation, Token | |||
| var endToken = tokenStream.GetTokenData(operation.EndToken); | |||
| var previousToken = endToken.GetPreviousTokenData(); | |||
|
|
|||
| return tokenStream.GetTriviaData(startToken, nextToken).TreatAsElastic || tokenStream.GetTriviaData(previousToken, endToken).TreatAsElastic; | |||
There was a problem hiding this comment.
getting TriviaData is not cheap. It allocates up front (The substring between tokesn). I looked into changing that, but it was non-trivial. so thsi was the expedient solution.
This was referenced May 15, 2024
|
Could someone please tell me what perf tool is being used in those screenshots? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes us from:
to:
(we actually call this in several places, which is why we get 800 MB drop).