Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache values in dependent project finder #73493

Merged
merged 16 commits into from
May 16, 2024
Merged

Cache values in dependent project finder #73493

merged 16 commits into from
May 16, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented May 15, 2024 •
edited
Loading

Removes like 60% of a lightbulb scenario:

image

image

Discovered when trying to figure out why a lightbulb was taking several seconds to load.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 15, 2024 20:05
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 15, 2024
@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun May 15, 2024 21:13
ToddGrun
ToddGrun approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 15, 2024 23:12
@CyrusNajmabadi CyrusNajmabadi merged commit 6d1245f into dotnet:main May 16, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 16, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the dependentProjectsFinder branch May 16, 2024 00:41
@dotnet-bot dotnet-bot mentioned this pull request May 18, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 21, 2024
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@sharwell sharwell mentioned this pull request Jun 20, 2024
Merged
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @Cosifne