Switch SG mode to 'balanced' by default #73618
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -50,5 +50,5 @@ public static WorkspaceConfigurationOptions GetWorkspaceConfigurationOptions(thi | |||
| SourceGeneratorExecutionPreferenceUtilities.GetEditorConfigString)); | |||
|
|
|||
| public static readonly Option2<bool> SourceGeneratorExecutionBalancedFeatureFlag = new( | |||
| "dotnet_source_generator_execution_balanced_feature_flag", false); | |||
| "dotnet_source_generator_execution_balanced_feature_flag", true); | |||
There was a problem hiding this comment.
note: we still have the feature flag. So we still have control-tower support to flip this back to 'false' if we run into any problems with this in the wild.
There was a problem hiding this comment.
Think we might need to have a modification here to leave it false by default for VSCode - I haven't yet had a chance to implement balanced mode there yet. Easiest way if you want to change the default is have a line of code in the language server project to explicitly set this to false - https://github.com/dotnet/roslyn/blob/main/src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs#L90
|
|
||
| // If we added or removed analyzers, then re-run all generators to bring them up to date. | ||
| if (hasAnalyzerChanges) | ||
| _projectSystemProjectFactory.Workspace.EnqueueUpdateSourceGeneratorVersion(projectId: null, forceRegeneration: true); |
There was a problem hiding this comment.
Why is projectId null here?
There was a problem hiding this comment.
that means "redo all generators".
There was a problem hiding this comment.
@CyrusNajmabadi For all projects though?
| Optional severity As RenameDashboardSeverity = RenameDashboardSeverity.None | ||
| ) As Tasks.Task | ||
| Optional severity As RenameDashboardSeverity = RenameDashboardSeverity.None, | ||
| Optional executionPreference As SourceGeneratorExecutionPreference = SourceGeneratorExecutionPreference.Automatic) As Task |
There was a problem hiding this comment.
It feels a bit odd to me that rename tests are concerning themselves with this -- it seems like this is just something the underlying system should be handling. But maybe I'm missing something here since I'm ramping back up on this space.
No description provided.