Slow down the work navbar does, and cancel updating it when receiving a high volume of user events #73680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a high volume of user events
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 23, 2024
src/EditorFeatures/Core/NavigationBar/NavigationBarController.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 23, 2024
| @@ -64,7 +64,7 @@ internal partial class NavigationBarController : IDisposable | |||
| /// compute the model once for every batch. The <c>bool</c> type parameter isn't used, but is provided as this | |||
| /// type is generic. | |||
| /// </summary> | |||
| private readonly AsyncBatchingWorkQueue<bool, NavigationBarModel?> _computeModelQueue; | |||
| private readonly AsyncBatchingWorkQueue<VoidResult, NavigationBarModel?> _computeModelQueue; | |||
There was a problem hiding this comment.
switched to VoidResult to make it clear this value isn't used.
CyrusNajmabadi
commented
May 23, 2024
| asyncListener, | ||
| _cancellationTokenSource.Token); | ||
|
|
||
| _selectItemQueue = new AsyncBatchingWorkQueue( | ||
| DelayTimeSpan.NearImmediate, | ||
| DelayTimeSpan.Short, |
There was a problem hiding this comment.
changed the cadence on this, couldn't observe any problem at this speed.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't perceive any issue changing this. And it helps us not hit the UI thread too often while doing something like scrolling quickly. There's little value in having the nav bars have to update that quickly, especially as it forces a UI thread switch that we're seeing in UI delays.