-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow down the work navbar does, and cancel updating it when receiving a high volume of user events #73680
Merged
Merged
Slow down the work navbar does, and cancel updating it when receiving a high volume of user events #73680
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8fde5f4
Slow down the work navbar does, and cancel updating it when receiving…
CyrusNajmabadi 458123f
Short delay
CyrusNajmabadi d1bfb49
Update src/EditorFeatures/Core/NavigationBar/NavigationBarController.cs
CyrusNajmabadi 4e27543
Fix comment
CyrusNajmabadi 690522a
Merge branch 'navBarCAdence' of https://github.com/CyrusNajmabadi/ros…
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,10 +61,9 @@ internal partial class NavigationBarController : IDisposable | |
|
||
/// <summary> | ||
/// Queue to batch up work to do to compute the current model. Used so we can batch up a lot of events and only | ||
/// compute the model once for every batch. The <c>bool</c> type parameter isn't used, but is provided as this | ||
/// type is generic. | ||
/// compute the model once for every batch. | ||
/// </summary> | ||
private readonly AsyncBatchingWorkQueue<bool, NavigationBarModel?> _computeModelQueue; | ||
private readonly AsyncBatchingWorkQueue<VoidResult, NavigationBarModel?> _computeModelQueue; | ||
|
||
/// <summary> | ||
/// Queue to batch up work to do to determine the selected item. Used so we can batch up a lot of events and | ||
|
@@ -93,15 +92,15 @@ public NavigationBarController( | |
_uiThreadOperationExecutor = uiThreadOperationExecutor; | ||
_asyncListener = asyncListener; | ||
|
||
_computeModelQueue = new AsyncBatchingWorkQueue<bool, NavigationBarModel?>( | ||
_computeModelQueue = new AsyncBatchingWorkQueue<VoidResult, NavigationBarModel?>( | ||
DelayTimeSpan.Short, | ||
ComputeModelAndSelectItemAsync, | ||
EqualityComparer<bool>.Default, | ||
EqualityComparer<VoidResult>.Default, | ||
asyncListener, | ||
_cancellationTokenSource.Token); | ||
|
||
_selectItemQueue = new AsyncBatchingWorkQueue( | ||
DelayTimeSpan.NearImmediate, | ||
DelayTimeSpan.Short, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed the cadence on this, couldn't observe any problem at this speed. |
||
SelectItemAsync, | ||
asyncListener, | ||
_cancellationTokenSource.Token); | ||
|
@@ -195,8 +194,7 @@ private void StartModelUpdateAndSelectedItemUpdateTasks() | |
if (_disconnected) | ||
return; | ||
|
||
// 'true' value is unused. this just signals to the queue that we have work to do. | ||
_computeModelQueue.AddWork(true); | ||
_computeModelQueue.AddWork(default(VoidResult)); | ||
} | ||
|
||
private void OnCaretMovedOrActiveViewChanged(object? sender, EventArgs e) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched to VoidResult to make it clear this value isn't used.