Expose Roslyn LSP types to XAML and add readme #73942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Jun 11, 2024
| @@ -1,59 +0,0 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
this was an unused project file sitting in the repo (probably from when these types got moved from internal)
dibarbet
force-pushed
the
expose_roslyn_lsp_xaml
branch
from
dfd0965 to
1cc34e2
Compare
mgoertz-msft
approved these changes
Jun 11, 2024
3 tasks
dibarbet
force-pushed
the
expose_roslyn_lsp_xaml
branch
from
1cc34e2 to
f752282
Compare
davidwengier
approved these changes
Jun 11, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're exposing Roslyn LSP types to Razor and XAML to allow them to consume them when they run as a separate language inside the same Roslyn language server instance.
This will allow us to drastically simplify our server implementation as we do not have to handle different request handlers for the same LSP request using different types, and allows them to call into Roslyn helpers with concrete LSP types (instead of doing complicated wrapping).