Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change commit to async when enter is pressed #75335

Merged
merged 28 commits into from
Oct 18, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Oct 2, 2024

Changes:

  1. Use CommitAsync in enter command handler, inline rename view model and legacy view model. (Three entries)
  2. Add an option to control the behavior.
  3. Check _renameService.ActiveSession.IsCommitInProgress in all other command handlers to prevent changes when rename is in progress.

TODO:
All the other callers of the sync version Commit should be revisited and change to call Cancel if needed.
I would like to make it a separate PR.

After the change it would looks like:
AsyncRename

@Cosifne Cosifne requested a review from a team as a code owner October 2, 2024 00:35
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 2, 2024
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great. i think we can cleanup and unify just a little more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants