Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Cancel() rather than Commit() when rename is async. #75562

Merged
merged 13 commits into from
Oct 22, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Oct 18, 2024

Following part of #75335

There are many command handlers handling Rename Session.
If the command is considered as invalid, like:

  1. Modify the workspace (making change outside the active renaming spans).
  2. Trigger code refactoring.
  3. Trigger rename again.

In all these cases, cancel the active rename session if globalOptionService.ShouldCommitAsynchronously() is true.

@Cosifne Cosifne requested a review from a team as a code owner October 18, 2024 22:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 18, 2024
@Cosifne Cosifne force-pushed the dev/shech/RenameCommandHandlerCancel branch from 7aadade to b24ed61 Compare October 18, 2024 23:46
@Cosifne Cosifne force-pushed the dev/shech/RenameCommandHandlerCancel branch from 29f1889 to a18a826 Compare October 18, 2024 23:59
@Cosifne Cosifne merged commit 42c572c into dotnet:main Oct 22, 2024
25 checks passed
@Cosifne Cosifne deleted the dev/shech/RenameCommandHandlerCancel branch October 22, 2024 21:27
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 22, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants