-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer Cancel() rather than Commit() when rename is async. #75562
Merged
Cosifne
merged 13 commits into
dotnet:main
from
Cosifne:dev/shech/RenameCommandHandlerCancel
Oct 22, 2024
Merged
Prefer Cancel() rather than Commit() when rename is async. #75562
Cosifne
merged 13 commits into
dotnet:main
from
Cosifne:dev/shech/RenameCommandHandlerCancel
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Oct 18, 2024
Cosifne
force-pushed
the
dev/shech/RenameCommandHandlerCancel
branch
from
October 18, 2024 23:46
7aadade
to
b24ed61
Compare
Cosifne
force-pushed
the
dev/shech/RenameCommandHandlerCancel
branch
from
October 18, 2024 23:59
29f1889
to
a18a826
Compare
src/EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Oct 21, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following part of #75335
There are many command handlers handling Rename Session.
If the command is considered as invalid, like:
In all these cases, cancel the active rename session if
globalOptionService.ShouldCommitAsynchronously()
is true.